Hi Michael, On Sat, Jun 23, 2018 at 11:23:58PM +0200, Michael Biebl wrote: > Package: git-buildpackage > Version: 0.9.9 > Severity: wishlist > > Hi, > > I recently ran into a bug in pristine-tar [1], which means at least for > the systemd package we can no longer use pristine-tar for the time > being. > > Imho it would be really useful if gbp in the absence of pristine-tar, > would pull the tarball from the Debian archive or the upstream location > instead of generating an orig.tar.gz on the fly (which most likely will > not have the same md5sum as the one currently in the archive).
I agree that having upstream tarballs should be simple. If pristine-tar can't be used we create the tarball as you noted but that tarball should have the same checksum when being created so if you're using gbp all the way there shouldn't be a problem. I don't disagree that we might want to fallback to fetching from the archive in certain situations like: 1.) create tarballs with stable checksums via either pristine-tar or by gbp 2.) verify checksum against the archive (or preferably against a checksum stored with the source tree so we have everything contained in the git archive) 3.) fetch if it doesn't match 1.) is already there 2.) would need to be done before we do 3.). Patches for that would be welcome. Does gbp not create a stable checksum when building tarballs for you? That would be a different bug. Cheers, -- Guido > > E.g. I have now explicitly turned off pristine-tar in gbp.conf for > systemd, and if I have removed the orig.tar.gz from my build/tarball > directory, so now I get: > > $ gbp buildpackage > gbp:info: Tarballs 'systemd_239.orig.tar.gz' not found at '../tarballs/' > gbp:info: Creating systemd_239.orig.tar.gz from 'upstream/239'