Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor

[Sean Whitton]

Source: dgit
Version: 5.10

When the test suite runs the user's configured editor can be invoked.
This can pop up new X windows and sometimes tests will fail.  Sometimes
it is git that is invoking the editor:

    + git commit
    Waiting for Emacs...*ERROR*: Quit

    error: There was a problem with the editor 'emacsclient -amg -c'.
    Please supply the message using either -m or -F option.
    + test 1 = 0
    + t-report-failure
    + set +x
    TEST FAILED
    cwd: /home/spwhitton/src/dgit/tests/tmp/overwrite-chkclog/example
    funcs: t-report-failure main
    lines: 1 0
    files: tests/lib tests/tests/overwrite-chkclog

And sometimes, it seems, dpkg-source (following output was with
EDITOR=nano VISUAL=nano):

    + pname=gitattrs
    + cat
    + EDITOR='perl -pi 
/home/spwhitton/src/dgit/tests/tmp/gitattributes/editor.pl'
    + dpkg-source -iX --commit . gitattrs
    dpkg-source: info: local changes detected, the modified files are:
     example.quilt-edit/.gitattributes
    
.[?1049h.[1;24r.[m.[4l.[?7h.[?1h.=.[?1h.=.[?1h.=.[39;49m.[?25l.[39;49m.[m.[H.[2J.[22;33H.[0;7m[
 Reading File ].[m.[22;32H.[0;7m[ Read 182 lines ].[m.[H.[39;49m.[0;7m  GNU 
nano 2.7.4   File: example.quilt-edit/debian/patches/gitattrs             
.[3;1H.[mDescription: <short summary of the patch>. TODO: Put a short 
summary on the line above and replace this paragraph. with a longer 
explanation of this change. Complete the meta-information. with other 
relevant fields (see below for details). To make it easier, the. 
information below has been extracted from the changelog. Adjust it or drop. 
it.. ..[10dexample (1.0-1) UNRELEASED; urgency=medium. ..[12d * 
convert.Author: Ian Jackson 
<ijack...@chiark.greenend.org.uk>.---.The information above should 
follow the Patch Tagging Guidelines, please.checkout 
http://dep.debian.net/deps/dep3/ to learn about the format. Here.are 
templates for supplementary fields that you might want to add:.Origin: 
<vendor|upstream|other>, <url of original patch>.Bug: <url in upstream 
bugtracker>..[0;7m^G.[m Get Help  .[0;7m^O.[m Write Out .[0;7m^W.[m Where 
Is  .[0;7m^K.[m Cut Text  .[0;7m^J.[m Justify   .[0;7m^C.[m Cur 
Pos..[0;7m^X.[m Exit.[14G.[0;7m^R.[m Read File .[0;7m^\.[m Replace   
.[0;7m^U.[m Uncut Text.[0;7m^T.[m To Spell  .[0;7m^_.[m Go To 
Line..[?12l.[?25h.[3d.[24;1H.[?1049l.[?1l.>Received SIGHUP or SIGTERM
    dpkg-source: error: sensible-editor gave error exit status 1
    + test 2 = 0
    + t-report-failure
    + set +x
    TEST FAILED
    cwd: /home/spwhitton/src/dgit/tests/tmp/gitattributes/example.quilt-edit
    funcs: t-report-failure quilt_addpatch sfmt_setup main
    lines: 1 105 241 0
    files: tests/lib tests/tests/gitattributes tests/tests/gitattributes 
tests/tests/gitattributes

It's pretty annoying to have new emacs frames popping up / the buffer
you are looking at switching to some temporary test suite file.

-- 
Sean Whitton

signature.asc
Description: PGP signature