On Mon, Jul 30, 2018 at 12:39:15PM +0200, Gianfranco Costamagna wrote: > Hello, > On Tue, 13 Oct 2015 18:30:15 -0400 William Blough <de...@blough.us> wrote: > > Source: pugixml > > Severity: wishlist > > > > The passwordsafe package uses pugixml, but requires wchar to be enabled. > > If a > > wchar enabled version (see pugiconfig.hpp) was included along side the > > current > > version, I could remove the embedded copy of pugixml from passwordsafe and > > depend on the packaged version instead. > > > > isn't this an ABI breaking change?
I'm not sure. This is why I suggested a separate version which could be marked as conflicting with the existing verison. This would at least guarantee that existing reverse dependencies wouldn't break. I realize now that this probably isn't a simple as it sounds. > please check if reverse-dependencies still work with the same ABI versioning > and wchar enabled, and provide a patch to make a proper transition. > I can help there, but I lack the time to do proper checks. If it's an ABI change, that can be handled, but I'm worried about non-ABI-related behavior changes breaking existing packages. I can try to test for some of those issues, but as I'm not familiar with any of the reverse dependencies, I'm concerned I may miss edge cases. That said, I'll look into it and see what I can figure out. Thanks, Bill
