On 31/07/18 17:44, Guilhem Moulin wrote: > Control: tag -1 pending > > On Tue, 31 Jul 2018 at 16:42:36 +0800, Tomasz Buchert wrote: > > I already committed a fix in > > https://salsa.debian.org/debian/signing-party/commit/c62477e3086c33af14493337227ec219f151d5b4. > > I pushed a fix to upstream/latest last week > https://salsa.debian.org/debian/signing-party/commit/ea3e3b52e308f36e9691c993c24b9100e8455811 > Just merged upstream/latest to debian/master and force-pushed the latter :-P
Oh, sorry for that. > Unfortunately it's not the first time people push changes to the default > (debian/master) branch, while I want the non-debian specific bits to > live on upstream/latest. I thus changed the permissions so non project > owners are not allowed to push to these two branches. :-P Patches are > still welcome, though! > > > I should also propose to use the colon format correctly, not with regexpes. > > :) > > AFAICT we were parsing it correctly. GnuPG <2.2.9 colon format for > field 11 was: > > | Signature class as per RFC-4880. This is a 2 digit hexnumber > | followed by either the letter 'x' for an exportable signature or > | the letter 'l' for a local-only signature. The class byte of an > | revocation key is also given here, 'x' and 'l' is used the same > | way. This field if not used for X.509. > > Since 2.2.9 (released on July 12) the following was added: > > | "rev" and "rvs" may be followed by a comma and a 2 digit hexnumber > | with the revocation reason. > > https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blobdiff;f=doc/DETAILS;h=eb6d7dd4b622027b30b3aecb94ce147c84fc9125;hp=1bfc04dd573ce46df21a1bfd36ff42d4badf5e1a;hb=b7cd2c2093ae1b47645be50fa1d431a028187cad;hpb=386b9c4f25b28fd769d7563f2d86ac3a19cc3011 > > That change breaks strict parsers. > -- > Guilhem. The DETAILS file also mentions to ignore fields that are not used. The current regexp based approach should be replaced with splitting-by-colon-and-fetching-necessary-index. Just saying :). Tomasz
signature.asc
Description: PGP signature
