Hi Dmitry, Thanks for the update!
On Fri, Aug 31, 2018 at 03:41:01PM +0300, Dmitry Eremin-Solenikov wrote: > Hello, > > I've uploaded new 1.19.0.2-1 version to mentors.d.o. > I've added manpages, fixed copyright info, fixed alternatives > and enabled auto-tests. Could you please review it? Build-dependency libibverbs-dev is missing. It failed to build from source because the linker cannot find -libverbs After adding that dependency I tried to build again however it ended up with a test failure. (also see the appendix part of this mail) http://debomatic-amd64.debian.net/distribution#unstable/odp/1.19.0.2-1/buildlog > сб, 2 июн. 2018 г. в 7:08, Lumin <cdlumin...@gmail.com>: > > > > On Sat, Jun 02, 2018 at 03:24:07AM +0000, Lumin wrote: > > > Please fix the aforementioned problems. Hopefully we'll have the last > > > round of check next time. Thank you for working on this. > > > > > > [1] > > > http://debomatic-amd64.debian.net/distribution#unstable/odp/1.19.0.1-1/buildlog > > > > Forgot to check the copyright ... The copyright looks incomplete. A > > simple search on the source tree would reveal many non-Linaro copyright > > holders: > > > > grep -ri copyright | grep -vi linaro | grep -i copyright > > > > The package will be rejected by ftp-master if we don't fix the > > copyright. > > Should be fixed now. Oops, you may have missed my second mail. The copyright file could be simpler by merging similar paragraphs into one instead one paragraph per file. A template can be generated with the following command: licensecheck -r --deb-machine . Which will automatically merge paragraphs. > > grep -ri copyright | grep -vi linaro | grep -i copyright ^ And I use this command for double-checking the copyright. Apart from that, these lintian complains should be fixed: I: odp source: wildcard-matches-nothing-in-dep5-copyright platform/linux-generic/odp_hash.c (paragraph at line 101) I: odp source: wildcard-matches-nothing-in-dep5-copyright m4/ax_check_compile_flag.m4 (paragraph at line 219) I: odp source: wildcard-matches-nothing-in-dep5-copyright m4/ax_compiler_vendor.m4 (paragraph at line 224) I: odp source: wildcard-matches-nothing-in-dep5-copyright m4/ax_compiler_version.m4 (paragraph at line 229) I: odp source: wildcard-matches-nothing-in-dep5-copyright m4/ax_pthread.m4 (paragraph at line 237) I: odp source: unused-file-paragraph-in-dep5-copyright paragraph at line 101 I: odp source: unused-file-paragraph-in-dep5-copyright paragraph at line 109 I: odp source: unused-file-paragraph-in-dep5-copyright paragraph at line 219 I: odp source: unused-file-paragraph-in-dep5-copyright paragraph at line 224 I: odp source: unused-file-paragraph-in-dep5-copyright paragraph at line 229 I: odp source: unused-file-paragraph-in-dep5-copyright paragraph at line 237 > > When checking odp-dpdk, one more problem was found: > > > > root@b69fed1c16e0 ~/odp-dpdk-1.19.0.0# update-alternatives --config > > libodp-linux.so-x86_64-linux-gnu > > There are 2 choices for the alternative libodp-linux.so-x86_64-linux-gnu > > (providing /usr/lib/x86_64-linux-gnu/libodp-linux.so). > > > > Selection Path > > Priority Status > > ------------------------------------------------------------ > > * 0 /usr/lib/x86_64-linux-gnu/odp-generic/libodp-linux.so 40 > > auto mode > > 1 /usr/lib/x86_64-linux-gnu/odp-dpdk/libodp-linux.so 40 > > manual mode > > 2 /usr/lib/x86_64-linux-gnu/odp-generic/libodp-linux.so 40 > > manual mode > > > > > > * 0 /usr/lib/x86_64-linux-gnu/odp-dpdk/libodp-linux.so.119 > > 60 auto mode > > 1 /usr/lib/x86_64-linux-gnu/odp-dpdk/libodp-linux.so.119 > > 60 manual mode > > 2 /usr/lib/x86_64-linux-gnu/odp-generic/libodp-linux.so.119 > > 40 manual mode > > > > Taking BLAS as an example, the generic and slow libblas3 provides > > libblas.so.3 symlink with a priority of 10. Faster implementations > > provides the same symlink with higher priorities, e.g. 40 for openblas. > > > > Maybe you want to adjust the priority values in those postinst scripts? > > The exact value is up to you, as long as it helps to tell the difference > > among different implementations. > > I'll fix odp-dpdk later. It's good as long as all odp-generic packages are assigned with the same priority, and odp-dpdk with a higher one. > -- > With best wishes > Dmitry > Appendix FAIL: scheduler/scheduler_main ============================== odp_ishm.c:936:_odp_ishm_reserve():No huge pages, fall back to normal pages. check: /proc/sys/vm/nr_hugepages. Queue config: queue_basic.max_queue_size: 8192 queue_basic.default_queue_size: 4096 Using scheduler 'basic' Scheduler config: sched_basic.prio_spread: 4 PKTIO: initialized loop interface. PKTIO: initialized dpdk pktio, use export ODP_PKTIO_DISABLE_DPDK=1 to disable. PKTIO: initialized pcap interface. PKTIO: initialized ipc interface. PKTIO: initialized null interface. PKTIO: initialized socket mmap, use export ODP_PKTIO_DISABLE_SOCKET_MMAP=1 to disable. PKTIO: initialized socket mmsg,use export ODP_PKTIO_DISABLE_SOCKET_MMSG=1 to disable. ODP API version: 1.19.0 ODP implementation name: odp-linux ODP implementation version: odp-linux 1.19.0-0 (v1.19.0) 1.19.0.2 CUnit - A unit testing framework for C - Version 2.1-3 http://cunit.sourceforge.net/ Max sched queue size 8192 Suite: Scheduler Test: scheduler_test_wait_time ...FAILED 1. scheduler.c:189 - odp_time_cmp(diff, upper_limit) <= 0
