Turbo Fredriksson skrev: >>Wouldn't it simpler to just remove the "#!NO_MODULE" then? What was the >>reason for putting in those lines in the upstream source? > > No, because there are checks in place for this string. Can't remember exactly > where I found it (I found it when packaging Roxen3 years ago), but at the > time, Roxen didn't see that the file(s) in question was modules without > that line.
I don't know exactly what #!NO_MODULE (or #!NO MODULE) does. Better
check with the Roxen guys directly. Do you remember your LysKOM
password? :-)
> If you unpack the pristine code, you'll see that there are files that have
> this line as well. I just added some more files to this 'list'.
>
[EMAIL PROTECTED]:~/src/roxen-dist-4.0.425-release5-ws/roxen-4.0.425-src$
grep -R "NO.MODULE" .
./roxen/server-4.0.425/etc/include/config.h:#ifndef NO_MODULE_LEVEL_SECURITY
./roxen/server-4.0.425/bin/sqladduser.pike:#!NO_MODULE
./roxen/server-4.0.425/modules/icecast/pl_common.pike:#!NO MODULE
./roxen/server-4.0.425/modules/throttling/throttlelib.pike:#!NO_MODULE
Just one more.
>>I don't think they are Roxen modules; they are just code common to the
>>modules. For instance, they don't have the module_type, module_name and
>>module_doc constants.
>
>
> Hmm. Okey, that IS a 'problem' though. All of them?
The two files in the original report all lack all three constants. But
it isn't a problem because you're not supposed to add pl_common.pike or
throttelib.pike to a site directly.
In any case, the fact remains, that the extra "#\n" causes compilation
errors and removing it makes the errors disappear. Maybe I should have
included the error messages in the original report. Here are some:
Administration Interface : Scripting: Pike script support : I dag,
klockan 12:17, 12:17 och 12:26
Failed to compile module
/usr/share/roxen4/modules/throttling/throttlelib.pike:
modules/throttling/throttlelib.pike:1 Error: Unknown preprocessor
directive.
----------------------------------------------------------------
Fel Administration Interface : Scripting: Pike script support : I dag,
klockan 12:26
Cast "/usr/share/roxen4/modules/throttling/throttlelib.pike" to program
failed in "/usr/share/roxen4/base_server/module_support.pike".
/usr/lib/pike/7.6.67/lib/master.pike (version 1.356):1010:
master()->cast_to_program("/usr/share/roxen4/modules/throttling/throttlelib.pike","/usr/share/roxen4/base_server/module_support.pike",UNDEFINED)
base_server/module_support.pike (version 1.120):49:
roxen->my_compile_file("/usr/share/roxen4/modules/throttling/throttlelib.pike",1)
base_server/module_support.pike (version 1.120):348:
ModuleInfo(throttlelib)->instance(0,1)
base_server/module_support.pike (version 1.120):433:
ModuleInfo(throttlelib)->init_module("/usr/share/roxen4/modules/throttling/throttlelib.pike")
base_server/module_support.pike (version 1.120):486:
ModuleInfo(throttlelib)->rec_find_module("throttlelib","/usr/share/roxen4/modules/throttling/")
base_server/module_support.pike (version 1.120):467:
ModuleInfo(throttlelib)->rec_find_module("throttlelib","/usr/share/roxen4/modules/")
base_server/module_support.pike (version 1.120):496:
ModuleInfo(throttlelib)->find_module("throttlelib")
base_server/module_support.pike (version 1.120):537:
ModuleInfo(throttlelib)->check(UNDEFINED)
base_server/module_support.pike (version 1.120):684:
roxen->find_module("throttlelib",1)
base_server/module_support.pike (version 1.120):633: roxen->all_modules()
config_interface/sites/add_module.pike:246:
/usr/share/roxen4/config_interface/sites/add_module()->get_module_list(/usr/share/roxen4/config_interface/sites/add_module()->__lambda_66857_3_line_318,/usr/share/roxen4/config_interface/sites/add_module()->class_visible_normal,,,0)
config_interface/sites/add_module.pike:404:
/usr/share/roxen4/config_interface/sites/add_module()->page_normal(@0=RequestID(/sites/add_module.pike?config=localhost&reload_module_list=yes),UNDEFINED)
config_interface/sites/add_module.pike:756:
/usr/share/roxen4/config_interface/sites/add_module()->parse(@01)
modules/scripting/pikescript.pike (version 1.73):133:
RoxenModule(Administration
Interface/pikescript#0)->call_script(/usr/share/roxen4/config_interface/sites/add_module()->parse,@011,/usr/lib/pike/7.6.67/lib/7.4/modules/Stdio.pmod/module.File("config_interface/sites/add_module.pike",
"r", 777 /* fd=34 */))
modules/scripting/pikescript.pike (version 1.73):253:
RoxenModule(Administration
Interface/pikescript#0)->handle_file_extension(@1=/usr/lib/pike/7.6.67/lib/7.4/modules/Stdio.pmod/module.File("config_interface/sites/add_module.pike",
"r", 777 /* fd=34 */),"pike",@0111)
base_server/configuration.pike (version 1.585):1974:
Configuration(Administration Interface)->low_get_file(@01111,UNDEFINED)
base_server/configuration.pike (version 1.585):2108:
Configuration(Administration
Interface)->get_file(@011111,UNDEFINED,UNDEFINED)
base_server/configuration.pike (version 1.585):2083:
Configuration(Administration Interface)->handle_request(@0111111,UNDEFINED)
protocols/http.pike (version 1.464):2031:
RequestID(/sites/add_module.pike?config=localhost&reload_module_list=yes)->handle_request()
base_server/roxen.pike (version 1.888):642: roxen->handler_thread(4).
signature.asc
Description: OpenPGP digital signature
