David Bremner <brem...@debian.org> writes: > Ian Jackson <ijack...@chiark.greenend.org.uk> writes: > > >> David, would a warning have been sufficient, to avoid this being a >> significant inconvenience to you ? Something like this perhsps: >> >> debian/source/options contains a tar-ignore option. >> If this option matches anything, dpkg-source's source >> package will differs from your git tree, and dgit push will fail. >> tar-ignore is not needed with dgit push, so you can remove it. > > It would have saved me some time. I don't really think "so you can > remove it" follows from "is not needed with dgit push". People use > dpkg-source outside dgit, and may have legitimate reasons for including > a tar-ignore option. In the case of notmuch it is used to prevent a > seperately downloadable performance corpus (400MB) from being included > in the debian source package. There might well be other ways to > accomplish the same goals, but every change required is a barrier to > using dgit.
As another example, since I removed tar-ignore from notmuch, I have W: notmuch source: diff-contains-git-control-dir .git/dgit/unpack/notmuch-0.27/.git E: notmuch source: source-contains-unsafe-symlink .git/dgit/unpack/notmuch-0.27/.git/objects (from lintian)
