Hi Daniel,
Daniel Shahaf wrote:
> Daniel Shahaf wrote on Tue, 18 Sep 2018 15:42 +0000:
> > Off the top of my head, we have several options:
> >
> > 1. Pass --with-pcre=foo to configure *and* make sure that configure dies
> > if pcre is not found. (The configure.ac patch can be upstreamed.)
> >
> > 2. After running configure, check that the pcre line in config.modules
> > has the expected values. (not upstreamable)
> >
> > 3. Patch Test/V07pcre to fail, rather than skip, if the PCRE module was
> > not built. (not upstreamable)
> >
> > We can do more than one of these, e.g., #1+#3.
>
> #3 is easy, attached.
> From 9c8883c924a4b69ca0b22b0f6a851a9d5eddf07a Mon Sep 17 00:00:00 2001
> From: Daniel Shahaf <danie...@apache.org>
> Date: Tue, 18 Sep 2018 16:30:24 +0000
> Subject: [PATCH] Make sure the build will fail if PCRE is not available.
Please don't be offended, but I don't think we should use a patch for
that feature.
The simplest way from my point of view is to check in an
override_dh_auto_test if the plugin file (pcre.so) is present or not.
Something like this:
override_dh_auto_test:
dh_auto_test
test -e [...]/zsh/pcre.so
with [...] being a wildcardy path to catch version numbers in the
path.
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
