On 9/19/18 12:38 PM, Simon McVittie wrote: > On Wed, 19 Sep 2018 at 11:38:37 +0200, John Paul Adrian Glaubitz wrote: >> mozjs60 currently fails to build from source on sh4 because gcc's >> register allocator on sh4 is failing for one source file. > > Thanks. When it builds with this patch, do the tests pass?
I didn't test but it shouldn't be any different than mozjs52. > In the current version, the test suite is completely skipped on some > architectures, but I'm trying some patches that change this so individual > failing tests are skipped if the failure doesn't look critical > (the wip/smcv branch in https://salsa.debian.org/gnome-team/mozjs60.git). > > I'm trying to avoid producing binaries on any architecture where they > don't at least mostly work, because otherwise, when another package tries > to use mozjs and can't, it falsely looks like the other package's fault > (as happened with mozjs24 on many architectures). I understand. But we're talking about Debian Ports. There are many other issues that need attention, so that one wouldn't make much of a difference. If mozjs60 caused other packages to break on sh4, I would eventually notice that and fix the packages. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913