Package: dh-golang Severity: important Tags: patch Hmm, I think the previous discussion in #908552 has no relation to this bug, although the result(incomplete Built-Using info) is same.
So I'm creating a new bug.
On Thu, Sep 27, 2018 at 09:06:34PM +0800, Shengjing Zhu wrote:
> I don't know perl enough, I just debug it with print...
> I debug it with packer(the package I maintain), which also misses some
> dependencies in Built-Using.
>
> It turns out the wrong logic in exec_chunked func.
>
> sub exec_chunked {
> my ($cmd, @list) = @_;
> my @result;
> for (my $i = 0; $i < @list; $i += CHUNKSIZE) {
> ^^^
> why this is not the length of the array?
> push @result, exec_single($cmd, splice(@list, $i, CHUNKSIZE));
> ^^^
> I find after this sentence, the @list
> array changes.
> }
> return @result;
> }
>
>
> Take packer as example, the uniq(@godeps) has 394 elements. But I find the
> exec_single only executed once, while the CHUNKSIZE is 200.
>
> tincho, could you help look at the perl code?
>
Coding with google and stackoverflow...
Here's the patch.
https://salsa.debian.org/go-team/packages/dh-golang/merge_requests/4
I've tested it with packer.
I think it should fix the problem.
Please review and test
(I've CCed #908552 for recording, but please leave comments on the new bug)
After this patch been uploaded, I may go to request binNMU for all go
packages before buster released.
But probably after we changed the Built-Using field to X-Go-Built-Using
(confirm with release/security team, see if this can be implemented without
changing d/control file, etc).
--
Shengjing Zhu
signature.asc
Description: PGP signature
