Hi, And thanks for checking with us (explicit Cc's welcome, by the way).
Alex Mestiashvili <ames...@rsh2.donotuse.de> (2018-10-11): > On 10/09/2018 07:39 PM, Nicholas D Steeves wrote: > > Control: retitle -1 please build libzstd udeb so that btrfs-progs can use > > zstd in Debian Installer > > Control: reassign -1 src:libzstd/ 1.3.5+dfsg-1 > > Done, dropped zstd-udeb. > > > Please read what Cyril (Debian Installer Team) wrote at these bugs in > > case these questions have already been answered: > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898410 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886968 > > Thank you, that was useful. > > I've updated the libzstd repository[0]. > > @Kibi, could you please review that? > > basically I just call dh_makeshlibs with -V'libzstd1 (>=1.3.5)' as there > are new symbols introduced in this version. From a quick look at debian/control: > Package: libzstd1-udeb > Architecture: any > Multi-Arch: same This field isn't needed for d-i. > Section: debian-installer > Depends: ${misc:Depends}, > ${shlibs:Depends} > Package-Type: udeb > Description: fast lossless compression algorithm > Zstd, short for Zstandard, is a fast lossless compression algorithm, > targeting > real-time compression scenarios at zlib-level compression ratio. > . > This package contains the shared library. > . > This is a minimal package for debian-installer. FWIW: A single-line description is sufficient in a d-i context. From a quick look at debian/rules, a real issue: > override_dh_makeshlibs: > dh_makeshlibs -plibzstd1 -V'libzstd1 (>=1.3.5)' > --add-udeb=libzstd-udeb You're passing libzstd-udeb to --add-udeb, while the actual package is called libzstd1-udeb, so the generated shlibs file (see DEBIAN/shlibs in your build tree) will point to a package that doesn't exist, generating dependencies that can be satisfied for udebs using symbols from libzstd. [I'm used to seeing a space after '>=' but apparently having no space seems supported as well: (sid-amd64-devel)kibi@armor:~/hack/libzstd$ grep '>=' /var/lib/dpkg/info/*shlibs | grep -v '>= ' /var/lib/dpkg/info/libgcrypt20:amd64.shlibs:libgcrypt 20 libgcrypt20 (>=1.8.0-0) /var/lib/dpkg/info/libgcrypt20:amd64.shlibs:udeb: libgcrypt 20 libgcrypt20-udeb (>=1.8.0-0) /var/lib/dpkg/info/libprocps6:amd64.shlibs:libprocps 6 libprocps6 (>=2:3.3.13-1) /var/lib/dpkg/info/libprocps7:amd64.shlibs:libprocps 7 libprocps7 (>=2:3.3.15-1) /var/lib/dpkg/info/libtasn1-6:amd64.shlibs:libtasn1 6 libtasn1-6 (>=4.7-0) ] Other than that, the resulting udeb after a binary build looks OK to me. Cheers, -- Cyril Brulebois (k...@debian.org) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
signature.asc
Description: PGP signature
