On Sat, 29 Sep 2018 10:48:49 +0200 Guido =?iso-8859-1?Q?G=FCnther?= <ag
[email protected]> wrote:
> Hi,
> On Fri, Sep 21, 2018 at 03:07:19PM +0200, Andreas Beckmann wrote:
> > On 2018-09-21 13:44, Guido Günther wrote:
> > >> In 'features' I've implemented two things:
> > >> * %(version)s substitution for tarball-dir
> > >> * preexport hooks that run before the tarballs get selected from
the
> > >>   tarball-dir (the hook can so some magic to bring the tarballs
into
> > >>   existence)
> > >> These are at least proof-of-concept implementations, they may
lack
> > >> proper documentation etc.
> > 
> > > The preexport and version substitution stuff looks good as well
and I'm
> > > happy to pull it in if it gets tests and doc updates (as you
> > > suggested).
> > 
> > I can write documentation if you point me to the correct files ...
> 
> Docs:
> 
>     docs/manpages/gbp-buildpackage.xml
> 
> If you want to add more details see
> 
>     docs/chapters/building.xml
> 
> Docs can be built with
> 
>      make -C docs
> 
> if you have gbp's build-deps installed.
> 
> > but I'm not sure how to write proper tests for these things.
> 
> For the preexport hook just extend
> 
>     https://git.sigxcpu.org/cgit/git-buildpackage/tree/tests/componen
t/deb/test_buildpackage.py#n53

Hi,

I've sent a PR with the preexport implementation (for RPM too), test
and documentation:

https://github.com/agx/git-buildpackage/pull/62

-- 
Kind regards,
Luca Boccassi

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to