Hi,

I uploaded a fixed version, and here are the patches to be consumed by git am.

I unhardcoded the PHP-FPM socket path, so your package can be binNMUed for the 
future transitions.

Ondrej


Attachment: 0001-Don-t-restart-phpX.Y-fpm-in-the-autopkgtests-it-s-no.patch
Description: Binary data

Attachment: 0004-Update-changelog-for-2018-07-17-1.2-release.patch
Description: Binary data

Attachment: 0003-Fix-the-nginx.conf-configuration-to-not-use-hardcode.patch
Description: Binary data

Attachment: 0002-Update-changelog-for-2018-07-17-1.1-release.patch
Description: Binary data

--
Ondřej Surý
ond...@sury.org



> On 5 Nov 2018, at 14:19, Ondřej Surý <ond...@sury.org> wrote:
> 
> Hi Johannes,
> 
> no, sorry, I didn’t test it as I don’t have the infrastructure at hand, but:
> 
> 1. it must work, you are not doing anything to php configuration in the test
> 2. if it doesn’t work, it’s a bug in phpX.Y-fpm package and needs to be 
> addressed.
> 
> Do you perhaps have nginx and fpm logs from your local testing?  The test in 
> your
> package in now correct, and I would be very happy to fix the php-fpm problem.
> 
> Ondrej
> --
> Ondřej Surý
> ond...@sury.org
> 
> 
> 
>> On 5 Nov 2018, at 14:03, Johannes Schauer <jo...@debian.org> wrote:
>> 
>> Hi Ondřej,
>> 
>> Quoting Ondřej Surý (2018-11-03 17:41:54)
>>> Just a simple observation - you don’t need to restart FPM as you don’t do 
>>> any
>>> modifications to the PHP FPM configuration.
>>> 
>>> So just drop the line:
>>> 
>>> systemctl restart php7.2-fpm
>>> 
>>> from d/t/general and the package tests will be fine again.
>> 
>> thanks for your NMU! But did you test it?
>> 
>> The reason I just didn't apply this change was, that dropping that line makes
>> the test not work. Did it work for you?
>> 
>> There is a reason I have that line in the script. Without that line, the
>> rss-bridge service didn't work. I suspect this has to do with me restarting
>> nginx or the like but I'm not sure.
>> 
>> I now still see a failure here:
>> 
>> https://ci.debian.net/data/autopkgtest/unstable/amd64/r/rss-bridge/1265818/log.gz
>> 
>> Are you sure you tested your change before upload?
>> 
>> Thanks!
>> 
>> cheers, josch
> 

Reply via email to