On Wed, Nov 14, 2018 at 09:39:01AM +0100, أحمد المحمودي wrote: > On Tue, Nov 13, 2018 at 09:53:29AM -0800, Steve Langasek wrote: > > > Is that patch correct? It doesn't seem to be building anything?
> > Because the test is 'Restrictions: build-needed', whenever the autopkgtest > > is run, the source package will automatically be rebuilt, and the test will > > fail if the rebuild fails. > ---end quoted text--- > I added this test, then later removed it, as lintian (or a DD, I don't > remember) complained that this is soke sort of a fake test. Sure. I don't agree that it's a fake test; you're running the test suite, which is only available in the harfbuzz build tree, and that is a useful thing which would have caught a real regression in a dependency (freetype) at test time. There are other ways that the autopkgtest could be constructed instead, perhaps to re-invoke the test suite from the build tree against the already-installed harfbuzz binary packages on the system. I have no particular opinion on this; I just think it's misguided to consider this a "fake" test when it is very much running the test suite. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature
