On Mon, Nov 19, 2018 at 02:56:18PM -0500, Scott Talbert wrote:
> On Mon, 19 Nov 2018, Olly Betts wrote:
> > On Mon, Nov 19, 2018 at 08:32:28AM +0000, Simon McVittie wrote:
> > > This bug can probably be fixed by passing EGREP="/bin/grep -E" as an
> > > additional command-line argument when invoking configure.
> >
> > That was my thought too.
> >
> > It would be nicer to address upstream, but I don't really see a way to
> > do that cleanly short of rewriting it to just use shell built-ins, which
> > seems like a lot of work as it's a hairy beast.
>
> Or we could just patch wx-config to set EGREP to "grep -E" (without the
> path)?
>
> https://salsa.debian.org/freewx-team/wx/blob/wx3.0-debian/wx-config.in#L92
If you mean as an upstream patch, then you need to worry about systems
where a suitable grep isn't on PATH (or where the PATH set when
configure was run isn't the same as the PATH set when wx-config gets
run).
If you mean as a debian-specific patch, that means we get to carry a
patch indefinitely. If it can be cleanly addressed by passing an extra
option to configure that seems better to me.
We can rely on "/bin/grep" continuing to work, it's just that
"/usr/bin/grep" only works when /usr == / (and presumably whichever
autoconf macro it is searches PATH and /usr/bin is before /bin on the
default PATH so it finds /usr/bin/grep first).
Cheers,
Olly
