On Thu, 6 Dec 2018, Serge Belyshev wrote:

> Indeed your version is better.  (Although as a minor nitpick
> bootclean.sh uses [ and -L in other places, so it will look inconsistent)

I’d recommend replacing at least the -L “while here anyway”.

Using test over [ is personal preference, but makes it IMHO
clearer to people not well-versed in shell that it’s an ex‐
ternal command with no magic syntax sugar regarding quoting
(which the Korn shell [[ has) and not comparable with the
normal if (…) in C.

Meow,
//mirabilos
-- 
„Cool, /usr/share/doc/mksh/examples/uhr.gz ist ja ein Grund,
mksh auf jedem System zu installieren.“
        -- XTaran auf der OpenRheinRuhr, ganz begeistert
(EN: “[…]uhr.gz is a reason to install mksh on every system.”)

Reply via email to