On Mon, Jun 04, 2018 at 10:49:00AM +0700, vinh.nguyenc...@toshiba-tsdv.com 
wrote:
> Attached file is the patch for this.

The patch looks quite complex and subtly wrong to me:

 * It uses DEB_BUILD_GNU_TYPE without initializing it.
 * It uses OS without initializing it.
 * When a user sets CC, it gets overwritten.

This is much easier solved with dh_auto_build, which doesn't use
uninitialized variables and honours a CC environment variable.

Helmut
diff --minimal -Nru pcal-4.11.0/debian/changelog pcal-4.11.0/debian/changelog
--- pcal-4.11.0/debian/changelog        2012-05-09 22:32:10.000000000 +0200
+++ pcal-4.11.0/debian/changelog        2018-12-15 00:39:01.000000000 +0100
@@ -1,3 +1,10 @@
+pcal (4.11.0-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Let dh_auto_build pass cross tools to make. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de>  Sat, 15 Dec 2018 00:39:01 +0100
+
 pcal (4.11.0-3) unstable; urgency=low
 
   * lintian fixes
diff --minimal -Nru pcal-4.11.0/debian/rules pcal-4.11.0/debian/rules
--- pcal-4.11.0/debian/rules    2012-04-11 21:39:35.000000000 +0200
+++ pcal-4.11.0/debian/rules    2018-12-15 00:38:55.000000000 +0100
@@ -15,7 +15,7 @@
 build-stamp:
        dh_testdir
 
-       $(MAKE) CFLAGS="-O2 -Wall -DEPS"
+       dh_auto_build -- CFLAGS="-O2 -Wall -DEPS"
 
        touch build-stamp
 

Reply via email to