>>>>> On Thu, 20 Dec 2018 13:15:01 +0100, Michael Schaller <mi...@google.com> 
>>>>> said:

    > I think this is a bit overkill. I would just duplicated the code that
    > you currently have for /boot:
    > 
https://github.com/faiproject/fai/blob/fe481ba1a3fea31c3748fc4becc625655e04b039/lib/setup-storage/Fstab.pm#L248

    > If the ESP is mounted on /boot then I think you could just set both
    > BOOT and ESP variables to the same values.

It's easy to write the ESP variables if setup-storage finds a
/boot/efi partition. But how should it decide if /boot is used as ESP
or if no UEFI is used at all? How can we detect this?

I would set the ESP variables if I find /boot/efi, and otherwise let
it undefined. But then the case that /boot is used as ESP is not
covered.

-- 
regards Thomas

Reply via email to