Bug#357734: lomoco: Prints uninitialized buffer.

[Nicolas CANIART]

Package: lomoco
Version: 1.0beta1+1.0-2
Severity: normal
Tags: patch

When lomoco encounters unknown logitech peripheral it outputs an
unitialized buffer on stdout (cf. lomoco.c:670:scan_bus()).
A few lines above : usb_get_string_simple() may not return proper ANSI/C
string so it is necessary to check its return value is not <0 before
printing the buffer.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-k7
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8)

Versions of packages lomoco depends on:
ii  libc6                         2.3.6-3    GNU C Library: Shared libraries an
ii  libusb-0.1-4                  2:0.1.11-6 userspace USB programming library

Versions of packages lomoco recommends:
ii  udev                          0.087-2    /dev/ and hotplug management daemo

-- no debconf information

diff -ruN lomoco-1.0beta1+1.0/src/lomoco.c 
lomoco-1.0beta1+1.0-patched/src/lomoco.c
--- lomoco-1.0beta1+1.0/src/lomoco.c    2006-03-01 15:10:05.000000000 +0100
+++ lomoco-1.0beta1+1.0-patched/src/lomoco.c    2006-03-18 14:33:16.000000000 
+0100
@@ -667,7 +667,7 @@
                                device->filename,
                                device->descriptor.idVendor,
                                device->descriptor.idProduct,
-                               ret ? product : "Unknown"
+                               ret > 0 ? product : "Unknown"
                                );
                        continue;
                }