On Wed, Feb 20, 2019 at 10:46:35AM +0200, Lars Wirzenius wrote:
> On Tue, Feb 19, 2019 at 03:34:35PM -0300, Antonio Terceiro wrote:
> > Only vmdb2 can know exactly what device is mounted as the image rootfs.
> > Therefore, the only reliable way of creating /etc/fstab to have a
> > working image, is to do that from withing vmdb2 itself.
> > 
> > Patch attached.
> 
> Thank you. Creating an fstab seems like a good idea. However, it looks
> to me like it only handles one mount point, and vmdb2 allows any
> number, e.g., /boot may be separate.
> 
> Would it make sense to change this so that it creates an fstab that
> has all mount points without them needing to be listed by the user? I
> think this should be doable by iterating over the tags structure. What
> do you think?

Yes, makes sense. I will come up with an updated patch.

Attachment: signature.asc
Description: PGP signature

Reply via email to