tags 352210 + patch thanks On Fri, Feb 10, 2006 at 02:24:52PM +0100, Claudio Sacerdoti Coen wrote:
> Temporary directories and files are created in /usr/share/websvn/temp.
> IMHO this behaviour is not compliant with FSH.
This seems to be caused by the upstream source which makes heavy use
of
tempnam("temp", "");
If I understand http://uk.php.net/tempnam correctly php should fall
back to the system's tempdir if it cannot create a tempfile in the
given directory; hence I assume that by _not_ providing
/usr/share/websvn/temp websvn should use the system default.
The attached patch implements this assumption.
HTH,
gregor
--
.''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
: :' : infos zur usenet-hierarchie at.*: http://www.usenet.at/
`. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/
`- NP: Element Of Crime: The Last Dance (Live)
diff -urN websvn-1.61/debian/dirs websvn-1.61.new/debian/dirs
--- websvn-1.61/debian/dirs 2006-03-19 23:19:46.000000000 +0100
+++ websvn-1.61.new/debian/dirs 2006-03-19 23:19:24.000000000 +0100
@@ -2,6 +2,5 @@
usr/share/websvn
usr/share/websvn/include
usr/share/websvn/languages
-usr/share/websvn/temp
usr/share/websvn/templates
var/cache/websvn
diff -urN websvn-1.61/debian/rules websvn-1.61.new/debian/rules
--- websvn-1.61/debian/rules 2006-03-19 23:19:46.000000000 +0100
+++ websvn-1.61.new/debian/rules 2006-03-19 23:19:24.000000000 +0100
@@ -24,7 +24,7 @@
echo '}' >> $(CURDIR)/debian/websvn/etc/websvn/config.inc
echo '?>' >> $(CURDIR)/debian/websvn/etc/websvn/config.inc
# main install
- for i in *.php languages templates include temp; do \
+ for i in *.php languages templates include; do \
cp -pr $(CURDIR)/$$i $(CURDIR)/debian/websvn/usr/share/websvn; \
done
# fix permissions
signature.asc
Description: Digital signature
