Hi, On 08-03-2019 09:38, Amos Jeffries wrote: > On 8/03/19 6:58 am, Paul Gevers wrote: >> On 07-03-2019 17:51, Luigi Gangitano wrote: >>> 4.6-2 has just been uploaded with a fix for 923213. I really appreciate >>> the opportunity to let it in Buster. >> >> Please file an unblock bug. I have one question about the proposed >> solution: you preinst doesn't honor local changes if the package is >> uninstalled (but not purged) and installed again AFAICT. > > How so? the preinst script only installs the disable symlink and skips > doing so if there is any existing profile. Everything else is done by > the debhelper script.
Because it does $(ln -sf) during install, even if the admin removed that link manually. If the package wasn't purged, the package must honor those changes by the admin in /etc/. > This particular chunk of the change is taken verbatim from what Ubuntu > have been using for years without an issue coming up. That may be true, it doesn't mean it is policy correct. On top of that, the autopkgtest fails, so you didn't fix it correctly. I suggest to revert the changes in the latest upload, disable the failing test, and I'll unblock the package (so the only delta with testing should be the disabled test). Paul
signature.asc
Description: OpenPGP digital signature
