22.03.2019 8:08, Uli Schlachter пишет: > Hi, > > On 22.03.19 00:53, T. Joseph Carter wrote: >> <-- nick (~u@h) has quit (Quit: ZNC 1.6.5+deb1+deb9u1 - http://znc.in) >> <-- nick (~u@h) has quit (Quit: ZNC 1.6.6+deb1ubuntu0.1 - http://znc.in) >> <-- nick (~u@h) has quit (Quit: ZNC 1.6.5+deb1+deb9u1 - http://znc.in) >> >> And one counter-example of how changing the default might be a good idea: >> >> <-- nick (~u@h has quit (Quit: ZNC - https://znc.in) > > This behaviour goes back to [1], I think. Before that, ZNC would do the > second kind of quit message. Commit [1] introduced an option called > "HideVersion", which defaults to "false". If this option is "false", the > function CZNC::GetTag() *always* includes version information. When set > to "true", CZNC::GetTag() only includes version information when told so > by its caller (seems to be: only the web interface for logged-in users).
No, before that commit, ZNC sometimes did expose the version, sometimes did not. That commit made it consistent, and configurable. I made it false by default to follow example of other software which exposes its version, e.g. nginx. > When I proposed to restore the old behaviour and instead to make > "HideVersion" also not include the version when explicitly told > otherwise, I was told that this is the way it is supposed to work. > AFAIR, the patch you proposed caused it to always hide the version, even for logged in users, and in znc --version > Anyway: Set "HideVersion = true" in your znc to get rid of the version > information. Webadmin can modify this setting, but controlpanel can not. > > If wanted, Debian could patch src/znc.cpp to change the default for > m_bHideVersion to true (the line looks like "m_bHideVersion(false)"). > > Cheers, > Uli > > [1]: > https://github.com/znc/znc/commit/f9a45076690990f75a14315db4f456e750073723 > -- Best regards, Alexey "DarthGandalf" Sokolov
