Package: git-email
Version: 1:2.20.1-2
Severity: normal
The value of the sendmail.transferencoding configuration item is ignored.
A patch has been submitted as
https://marc.info/?l=git&m=155483810827726&w=2
The patch is also appended.
Best regards
Heinrich Schuchardt
From f3afc36a7c624f300739ab43fd56b9e4850db6a5 Mon Sep 17 00:00:00 2001
From: Heinrich Schuchardt <xypron.g...@gmx.de>
Date: Tue, 9 Apr 2019 21:03:43 +0200
Subject: [PATCH 1/1] send-email: fix transferencoding config option
Since e67a228cd8a ("send-email: automatically determine transfer-encoding")
the value of sendmail.transferencoding is ignored because when parsing
the configuration $target_xfer_encoding is not initial anymore.
Instead of initializing variable $target_xfer_encoding on definition we
have to set it to the default value of 'auto' if is initial after parsing
the configuration files.
The documentation erroneously mentions the option as
sendmail.transferEncoding. Fix that typo.
Fixes: e67a228cd8a ("send-email: automatically determine transfer-encoding")
Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
---
Documentation/git-send-email.txt | 2 +-
git-send-email.perl | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 1afe9fc858..884e776add 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -146,7 +146,7 @@ Note that no attempts whatsoever are made to validate the encoding.
even more opaque. auto will use 8bit when possible, and quoted-printable
otherwise.
+
-Default is the value of the `sendemail.transferEncoding` configuration
+Default is the value of the `sendemail.transferencoding` configuration
value; if that is unspecified, default to `auto`.
--xmailer::
diff --git a/git-send-email.perl b/git-send-email.perl
index 8200d58cdc..0e23193939 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -239,7 +239,7 @@ sub do_edit {
my (@suppress_cc);
my ($auto_8bit_encoding);
my ($compose_encoding);
-my $target_xfer_encoding = 'auto';
+my ($target_xfer_encoding);
my ($debug_net_smtp) = 0; # Net::SMTP, see send_message()
@@ -446,6 +446,8 @@ sub read_config {
$smtp_encryption = 'ssl';
}
}
+
+ $target_xfer_encoding = 'auto' unless (defined $target_xfer_encoding);
}
# read configuration from [sendemail "$identity"], fall back on [sendemail]
--
2.20.1
