On Fri, Jun 14, 2019 at 09:42:54AM +0200, Victor Seva wrote:
On Thu, 13 Jun 2019 at 13:09, gustavo panizzo <g...@zumbi.com.ar> wrote:

I've been working on how to maintain and update the prosody config

this was my initial attempt using a Makefile
https://salsa.debian.org/rtc-team/prosody-configuration

this is my current attempt using puppet and the module Victor suggested

https://salsa.debian.org/gfa/dsa-puppet/merge_requests/1/diffs

this is depending this merge
https://github.com/voxpupuli/puppet-posix_acl/pull/62 if the merge takes
to long I'll fork the module in salsa

My goal for the first iteration is to have the patch merged by DSA so we
can have a way to deploy changes in the service easily and
auditable, afterwards (help welcomed!) I'll add anti-spam measures and
http_uploads :)

reviews of the MR are very much welcomed


This is great!

Some comments:

* the need of posix_acl maybe is not necessary. This was needed to do
manual changes to the configs. If We can manage the config via puppet I
think is not really needed. Maybe without posix_acl it would be easier to
get approved by DSA. Being able to read /var/log/prosody/ is good enough to

I think is good to let the rest of the team (debvoip) to be able to read
the config files after being generated by puppet
If DSA don't like the posix_acl module i'd resort to call setfacl in an exec [1]


check and debug the service.
* can you please explain and document how to get the "generated" configs.
In other words, how to test this in a VM with puppet masterless.


i'm using puppet bolt, my repo is published [2] but I haven't commited
the prosody config yet, but is just a wrapper class (like
debian_org::prosody) called from hiera


I'm moving next week, don't expect much from me until next
weekend or so

Great work Gustavo. Thank you for this!
Cheers,
Victor

[1] https://puppet.com/docs/puppet/5.5/types/exec.html
[2] https://github.com/gfa/puppet-bolt

--
IRC: gfa
GPG: 0x27263FA42553615F904A7EBE2A40A2ECB8DAD8D5
OLD GPG: 0x44BB1BA79F6C6333

Reply via email to