On 6/17/19 7:41 AM, Jonathan Wiltshire wrote: > On Mon, Jun 17, 2019 at 12:59:10AM +0200, Thomas Goirand wrote: >> I don't think people read more the NEWS than the changelog. > > I'm not sure how you arrive at that conclusion, but here's a consideration: > it's my company's policy that the NEWS are read during every upgrade of a > client system (and our own) to catch surprises like this. It is a good > example of exactly what NEWS files are for. > > Popcon also suggests that 85% of respondents have apt-listchanges > installed, which is the package giving this behaviour. > > So I disagree with your statement that it is a waste of time documenting a > surprising behaviour change like this. As Micah demonstrates, local > administrators upgrading may already have a mechanism to deal with the > problem and your cron job will conflict with that. > >> Having run puppet on a small virtual machine with 40 GB disk, and having >> it taken down by 800 MB reports every day for every compute in the >> cluster, no, this isn't controversial. This is completely mandatory. >> What I believe puppet user do is set this up by themselves, or disable >> reports all together. Keeping 1 month of reports is very conservative. > > I don't disagree with the problem statement. > > > Thanks,
Hi, Thanks for your insightful point of view. Please see the new attached debdiff for version 5.5.10-4, which includes the suggested NEWS file. Cheers, Thomas Goirand (zigo)
diff -Nru puppet-5.5.10/debian/changelog puppet-5.5.10/debian/changelog --- puppet-5.5.10/debian/changelog 2019-03-12 11:51:05.000000000 +0100 +++ puppet-5.5.10/debian/changelog 2019-06-17 11:44:21.000000000 +0200 @@ -1,3 +1,19 @@ +puppet (5.5.10-4) unstable; urgency=medium + + * Team upload. + * Added a puppet-master.NEWS file, as suggested by the release team. + + -- Thomas Goirand <z...@debian.org> Mon, 17 Jun 2019 11:44:21 +0200 + +puppet (5.5.10-3) unstable; urgency=medium + + * Team upload. + * Add a cron.daily job to clean-up /var/lib/puppet/reports for any report + that is older than 30 days to avoid filling-up a puppet-master hard drive + until it's full (Closes: #930033). + + -- Thomas Goirand <z...@debian.org> Thu, 06 Jun 2019 10:24:27 +0200 + puppet (5.5.10-2) unstable; urgency=medium * Make sure oj does not use BigDecimals on data load (Closes: #923976) diff -Nru puppet-5.5.10/debian/puppet-master.cron.daily puppet-5.5.10/debian/puppet-master.cron.daily --- puppet-5.5.10/debian/puppet-master.cron.daily 1970-01-01 01:00:00.000000000 +0100 +++ puppet-5.5.10/debian/puppet-master.cron.daily 2019-06-17 11:44:21.000000000 +0200 @@ -0,0 +1,7 @@ +#!/bin/sh + +if [ -e /var/lib/puppet/reports ] ; then + find /var/lib/puppet/reports -maxdepth 2 -type f -ctime +30 -delete +fi + +exit 0 diff -Nru puppet-5.5.10/debian/puppet-master.NEWS puppet-5.5.10/debian/puppet-master.NEWS --- puppet-5.5.10/debian/puppet-master.NEWS 1970-01-01 01:00:00.000000000 +0100 +++ puppet-5.5.10/debian/puppet-master.NEWS 2019-06-17 11:44:21.000000000 +0200 @@ -0,0 +1,7 @@ +puppet (5.5.10-3) unstable; urgency=medium + + * Add a cron.daily job to clean-up /var/lib/puppet/reports for any report + that is older than 30 days to avoid filling-up a puppet-master hard drive + until it's full (Closes: #930033). + + -- Thomas Goirand <z...@debian.org> Thu, 06 Jun 2019 10:24:27 +0200