On Tue, 11 Jun, 2019 at 12:18 PM, Paolo Greppi <paolo.gre...@libpf.com> wrote:
On 11/06/19 08:03, Pirate Praveen wrote:
I think rollup-plugin-commonjs will also work without extra options, see node-d3-fetch.


rollup-plugin-commonjs is already there in the upstream rollup config:
https://salsa.debian.org/js-team/vue-router.js/blob/master/build/configs.js#L4

P.

Ah I think I got what is going on. If the package is using require, we need commonjs plugin and if it is using imports, we need node-resolve and the package should install the ES modules. Just figured this us when trying to build d3, the d3-* sub modules did not install src direcotry and was showing Unresolved dependencies even after adding node-resolve. It worked after install src directory in dependencies (see last commits in node-d3-array).

Reply via email to