Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian....@packages.debian.org
Usertags: pu
Hi,
It looks like the bug I opened isn't there, so I'm reporting this again,
sorry if there's twice the same p-u bug.
Please allow me to fix puppet-module-cinder in Buster. The attached debdiff
shows that, when using the CEPH backend, puppet-cinder attemps to write in
/etc/init, which fails since we don't have this upstart folder anymore.
I failed to see this bug until I attempted to add a CEPH backend (instead
of the "regular" LVM backend) in my cluster.
Debdiff attached.
Cheers,
Thomas Goirand (zigo)
diff -Nru puppet-module-cinder-13.1.0/debian/changelog
puppet-module-cinder-13.1.0/debian/changelog
--- puppet-module-cinder-13.1.0/debian/changelog 2018-11-28
15:58:01.000000000 +0100
+++ puppet-module-cinder-13.1.0/debian/changelog 2019-07-04
14:59:42.000000000 +0200
@@ -1,3 +1,9 @@
+puppet-module-cinder (13.1.0-3+deb10u1) buster; urgency=medium
+
+ * Add missing Ceph patch: Do_not_attempt_to_write_in_etc_init.patch.
+
+ -- Thomas Goirand <z...@debian.org> Thu, 04 Jul 2019 14:59:42 +0200
+
puppet-module-cinder (13.1.0-3) unstable; urgency=medium
* Add 0001-Add-File.expand_path-to-cinder.rb.patch.
diff -Nru
puppet-module-cinder-13.1.0/debian/patches/Do_not_attempt_to_write_in_etc_init.patch
puppet-module-cinder-13.1.0/debian/patches/Do_not_attempt_to_write_in_etc_init.patch
---
puppet-module-cinder-13.1.0/debian/patches/Do_not_attempt_to_write_in_etc_init.patch
1970-01-01 01:00:00.000000000 +0100
+++
puppet-module-cinder-13.1.0/debian/patches/Do_not_attempt_to_write_in_etc_init.patch
2019-07-04 14:59:42.000000000 +0200
@@ -0,0 +1,29 @@
+Description: Do not attempt to write in /etc/init
+ manifests/backend/rbd.pp attempts to write in /etc/init, when
+ upstart has long gone. The result is that it just fails to run.
+ So let's remove this, as it's broken.
+From: Thomas Goirand <z...@debian.org>
+Date: Sat, 13 Apr 2019 21:34:37 +0200
+Change-Id: I7666c775f4d269f214d3f853e56d0eb076834164
+Forwarded: https://review.openstack.org/#/c/652209/
+Last-Update: 2019-04-13
+
+Index: puppet-module-cinder/manifests/backend/rbd.pp
+===================================================================
+--- puppet-module-cinder.orig/manifests/backend/rbd.pp
++++ puppet-module-cinder/manifests/backend/rbd.pp
+@@ -144,14 +144,4 @@ define cinder::backend::rbd (
+ fail("unsupported osfamily ${::osfamily}, currently Debian and Redhat
are the only supported platforms")
+ }
+ }
+-
+- # Creates an empty file if it doesn't yet exist
+- ensure_resource('file', $::cinder::params::ceph_init_override, {'ensure' =>
'present'})
+-
+- file_line { "set initscript env ${name}":
+- line => $override_line,
+- path => $::cinder::params::ceph_init_override,
+- notify => Anchor['cinder::service::begin'],
+- }
+-
+ }
diff -Nru puppet-module-cinder-13.1.0/debian/patches/series
puppet-module-cinder-13.1.0/debian/patches/series
--- puppet-module-cinder-13.1.0/debian/patches/series 2018-11-28
15:58:01.000000000 +0100
+++ puppet-module-cinder-13.1.0/debian/patches/series 2019-07-04
14:59:42.000000000 +0200
@@ -1 +1,2 @@
0001-Add-File.expand_path-to-cinder.rb.patch
+Do_not_attempt_to_write_in_etc_init.patch
