Package: debhelper
Version: 12.2
Severity: important
Control: affects -1 src:nethack

Hi,

I noticed when upgrading nethack, dh_shlibdeps no longer finds the main
nethack ELF binaries. debhelper 12.1.1 works correctly.

With 12.1.1:
$ dh_shlibdeps -v
dh_shlibdeps -v
        dpkg-shlibdeps -Tdebian/nethack-common.substvars
debian/nethack-common/usr/lib/games/nethack/dlb
debian/nethack-common/usr/lib/games/nethack/lev_comp
debian/nethack-common/usr/lib/games/nethack/dgn_comp
debian/nethack-common/usr/lib/games/nethack/recover
        dpkg-shlibdeps -Tdebian/nethack-console.substvars
debian/nethack-console/usr/lib/games/nethack/nethack-console
        dpkg-shlibdeps -Tdebian/nethack-lisp.substvars
debian/nethack-lisp/usr/lib/games/nethack/nethack-lisp
        dpkg-shlibdeps -Tdebian/nethack-x11.substvars
debian/nethack-x11/usr/lib/games/nethack/nethack-x11

With 12.2:
$ dh_shlibdeps -v
        dpkg-shlibdeps -Tdebian/nethack-common.substvars
debian/nethack-common/usr/lib/games/nethack/dlb
debian/nethack-common/usr/lib/games/nethack/lev_comp
debian/nethack-common/usr/lib/games/nethack/dgn_comp
debian/nethack-common/usr/lib/games/nethack/recover


I think this is caused by the fix for #931996. Nethack installs these
files with the setgid bit by default, which changes the output of file
in a way that's no longer detected properly:

$ file --brief debian/nethack-x11/usr/lib/games/nethack/nethack-x11
setgid ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV),
dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2,
BuildID[sha1]=1485534d83c00eb43ac9e8ddf15cab6c5b062ad7, for GNU/Linux
3.2.0, stripped

It's pretty easy to fix this in nethack if I need to, but I don't think
something like this should break in debhelper without a compat bump.

James

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to