You are right, the change was reverted (partly) which is the reason why
I couldn't find the bug on Git.
Indeed the other issue is that, if the state-daemon.conf exists, none of
the two services starts.
The initial bug that caused this "bad" fix is also something I recognise
on e.g. Stretch systems. One must safe audio controls one time manually
and at best start alsa-restore.service once to have it storing on
shutdown and restoring on boot automatically.
If I am not mistaken, after back and forth, this initial "bug" is now
unresolved again. The problem is that alsa-restore.service does now
still not start, if the state file does not exist, thus does not store
states on shutdown, thus will never be active without manual storing:
https://salsa.debian.org/alsa-team/alsa-utils/blob/debian/master/alsactl/alsa-restore.service.in#L10
Removing that condition was already mentioned in the comments and IMO
totally makes sense. ExecStart already allows the failure, thus service
state will be active, thus ExecStop will be called after which
everything will be as intended.
Another solution of course would be to either include "alsactl store"
into the package postinst script or create an empty file (if not
existent) or something similar, but the above is more failsafe if for
some reason the state file gets removed.
Best regards,
Micha
