Hello,removing it is fine, however marking it as optional might be the best
solution to avoid build failures on backports or wherever gcc-8 is still the
default...
G.
Il venerdì 19 luglio 2019, 16:04:51 CEST, Yangfl <mmyan...@gmail.com> ha
scritto:
Gianfranco Costamagna <locutusofb...@debian.org> 于2019年7月19日周五 下午6:03写道：
>
> Source: libminini
> Version: 1.2.a+ds-2
> Tags: patch
>
> hello, please apply this patch to the symbols file
>
> +libminini (1.2.a+ds-3) unstable; urgency=medium
> +
> + * Mark an internal symbol as optional (Closes: #-1)
> +
> + -- Gianfranco Costamagna <locutusofb...@debian.org> Fri, 19 Jul 2019
> 11:49:22 +0200
> +
> libminini (1.2.a+ds-2) unstable; urgency=medium
>
> * Fix FTBFS with GCC-9 (Closes: #925751)
> diff -Nru libminini-1.2.a+ds/debian/libminini1.symbols
> libminini-1.2.a+ds/debian/libminini1.symbols
> --- libminini-1.2.a+ds/debian/libminini1.symbols 2019-07-12
> 17:29:01.000000000 +0200
> +++ libminini-1.2.a+ds/debian/libminini1.symbols 2019-07-19
> 11:49:21.000000000 +0200
> @@ -17,7 +17,7 @@
> (c++)"minIni::browse(int (*)(char const*, char const*, char const*, void*),
>void*) const@Base" 1.2.a
> (c++)"minIni::getkey(std::__cxx11::basic_string<char,
>std::char_traits<char>, std::allocator<char> > const&, int) const@Base" 1.2.a
> (c++)"minIni::getbool(std::__cxx11::basic_string<char,
>std::char_traits<char>, std::allocator<char> > const&,
>std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
>> const&, bool) const@Base" 1.2.a
> - (c++)"void std::__cxx11::basic_string<char, std::char_traits<char>,
> std::allocator<char> >::_M_construct<char const*>(char const*, char const*,
> std::forward_iterator_tag)@Base" 1.2.a
> + (c++|optional)"void std::__cxx11::basic_string<char,
> std::char_traits<char>, std::allocator<char> >::_M_construct<char
> const*>(char const*, char const*, std::forward_iterator_tag)@Base" 1.2.a
> ini_browse@Base 1.2.a
> ini_getbool@Base 1.2.a
> ini_getf@Base 1.2.a
>
>
> that symbol is probably not exported anymore in gcc-9, this is why you can't
> see the issue yet in Debian
>
> cheers,
>
> Gianfranco
Hmm, I just removed it in order to fix #925751, neither does it appear
in the latest buildd log
https://buildd.debian.org/status/fetch.php?pkg=libminini&arch=amd64&ver=1.2.a%2Bds-2&stamp=1563481050&raw=0
. Is there any need to add it back?
