Hi! On Mon, 2019-07-29 at 13:49:45 +0200, Paul Sonnenschein wrote: > Package: lxqt-config > Severity: important > Version: 0.14.1-2 > Tags: patch > User: debian-h...@lists.debian.org > Usertags: hurd > > the package lxqt-config fails to build from source on hurd-i386 because > udev is not available on non-linux (on kfreebsd-any, it is in state BD- > Uninstallable).
> diff --git a/debian/rules b/debian/rules > index 4f7c70d..81335e7 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -5,6 +5,12 @@ export LC_ALL=C.UTF-8 > export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed > export DEB_BUILD_MAINT_OPTIONS = hardening=+all > > +WHICH_OS := $(shell dpkg-architecture -qDEB_HOST_ARCH_OS 2>/dev/null) The usual convention is to use the same name as the queried variable, so «DEB_HOST_ARCH_OS = ...», but I think even better would be to just do «include /usr/share/dpkg/architecture.mk» and then just use the needed variables lazily defined there. > +ifneq ($(WHICH_OS), linux) > + NOT_LINUX := -DWITH_TOUCHPAD=NO > +endif To make this variable reusable, I'd probably give it a system agnostic name, I tend to use something like: confflags += -DWITH_TOUCHPAD=NO so that it can be extended, w/o rendering the name invalid. Thanks, Guillem
