On Sat, 2019-07-20 at 14:57 -0400, Daniel Kahn Gillmor wrote:
> Control: tags 932474 + moreinfo
> 
> Hi Jeremiah--

Hello Daniel!

> On Fri 2019-07-19 17:24:34 -0400, Jeremiah C. Foster wrote:
> > I would like to add a USB VID:PID pair to the scdaemon package,
> > please find a diff attached.
> 
> I'm really happy to see Librem getting this stuff working, and I'd be
> happy to try to get this merged shortly.

Thank you in advance.

> > +## Librem Key
> > +SUBSYSTEM=="usb", ATTR{idVendor}=="4c4b", ATTR{idProduct}=="4c05",
> > ENV{ID_SMARTCARD_READER}="1",
> > ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
> 
> I'm sure you understand that we don't want to misattribute either
> vendorIDs or vendors.

I do understand that and am grateful for the attention to detail.

>   I tried to look up 0x4c4b (19531 decimal) in the
> "Valid USB Vendor ID Numbers" list distributed by the USB
> implementers
> forum here:
> 
>     https://www.usb.org/developers
> 
> It says it's update quarterly, but the version i looked at is from
> late
> May:
> 
>     https://usb.org/sites/default/files/vendor_ids052019.pdf
> 
> Was this a recently-assigned vendor ID? 

Yes, but I must apologize for providing you incorrect infomation.
Purism's vendor ID is actually 12653 or 0x316d.

>  Can you provide some evidence
> of the assignment?

The document you point to shows our assignment of 0x316d as "Purism
SPC". Of course our patch has to be updated accordingly -- please find
attached an updated patch.

Many thanks,

Jeremiah
--- /lib/udev/rules.d/60-scdaemon.rules-o	2019-07-19 13:48:34.591954821 -0700
+++ /lib/udev/rules.d/60-scdaemon.rules	2019-07-19 13:49:50.319551666 -0700
@@ -36,6 +36,8 @@
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4108", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4109", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 SUBSYSTEM=="usb", ATTR{idVendor}=="20a0", ATTR{idProduct}=="4211", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
+## Librem Key
+SUBSYSTEM=="usb", ATTR{idVendor}=="316d", ATTR{idProduct}=="4c4b", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 ## Gnuk Token
 SUBSYSTEM=="usb", ATTR{idVendor}=="234b", ATTR{idProduct}=="0000", ENV{ID_SMARTCARD_READER}="1", ENV{ID_SMARTCARD_READER_DRIVER}="gnupg"
 ## Alcor Micro Corp cardreader (in ThinkPad X250)

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to