Hi Helmut.

Am Montag, den 27.05.2019, 09:47 +0200 schrieb Martin Steigerwald:
> Helmut Grohne - 26.05.19, 16:22:
> > Source: fio
> > Version: 3.12-2
[…]
> > fio fails to cross build from source, because it configures for the
> > build architecture. fio's configure is very different from autotools
> > and requires the user to export a variable called CROSS_COMPILE.
> > Even
> > then, it uses the wrong pkg-config and runs compiled executables.
> > The
> > attached patch makes fio cross buildable. Please consider applying
> > it.
[…]
> It appears to me that your change would make sense for upstream to
> consider, as according to you there is a bug with cross building in
> fio's own configure logic.  If so it might make the most sense to
> propose the change to upstream via f...@vger.kernel.org (cc to Jens
> Axboe <ax...@kernel.dk> and me please), in order to keep the Debian
> diff to a minimum. Especially as your patch changes several non-
> consecutive lines.
[…]
> According to the debdiff your patch does not contain a Author: and
> Description: line. Please add those.
>
> Please consider issuing a merge request for your change then¹.
[…]

I updated the packaging to fio-3.15 which should contain the patches you
submitted to upstream.

Please provide a merge request for the Debian specific changes that are
needed to enable cross-building. In case you need to make Debian
specific changes to the upstream source code, please make sure your
patch contains Author: and Descripton: lines.

Please document your changes in the changelog under your name.

Please also test cross building before submitting your merge request.

The package uses git-buildpackage so please use 'gbp clone' to clone the
repository and branch from 'master' branch to generate your merge
request, which should contain only changes in 'debian' directory.

> [1] https://salsa.debian.org/debian/fio

Thanks,

Mit freundlichen Grüßen / With kind regards
Martin Steigerwald •
Proact Deutschland GmbH
Trainer
Telefon: +49 911 30999 0 •
Fax: +49 911 30999 99
Südwestpark 43 •
90449 Nürnberg •
Germany
martin.steigerw...@proact.de •
www.proact.de
Amtsgericht Nürnberg
 •
HRB 18320
Geschäftsführer:
Oliver Kügow •
Richard Müller •
Jakob Høholdt
 •
Peter Mikael Javestad
– Delivering Business Agility –

Reply via email to