On 7/4/19 5:21 AM, Masahiro Honda wrote:
> Here is a patch.

Thanks for the bug report and the patch!

> --- ntpsec-ntpdate.orig       2019-02-14 11:30:00.899998213 +0000
> +++ ntpsec-ntpdate    2019-07-04 09:35:51.210653439 +0100
> @@ -31,11 +31,12 @@
>  fi
>  
>  service="ntpsec"
> +export service

This looks to be the critical fix. I will merge this change.

>  invoke-rc.d --quiet "$service" stop >/dev/null 2>&1 || true
>  
>  # Avoid running more than one at a time
> -flock -n /run/lock/ntpsec-ntpdate /usr/sbin/ntpdate-debian -s $OPTS 
> 2>/dev/null || :
> +flock -n /run/lock/ntpsec-ntpdate /usr/sbin/ntpdate-debian $OPTS 2>/dev/null 
> | logger -t ntpsec-ntpdate || :

This change does two things. It removes -s from flock and it adds logging.

The -s seems to allow multiple ntpdate-debian processes to run
simultaneously, which seems bad. It seems like a correct change to
remove that, though it makes me wonder why it was there in the first
place. (This code was inherited from the ntp package.)

Are you getting interesting logging when ntpdate-debian runs?

-- 
Richard

Reply via email to