Hi Kunal, Thank you for your report.
Le 06/08/2019 à 22:33, Kunal Mehta a écrit : > 0005-Pick-up-copyright-instead-of-LICENSE.patch switches the composer autoload > generator to use debian/copyright instead of upstream's LICENSE file. This is > problematic for a few reasons: > > First, vendor/ directories are no longer identical with people who use an > upstream version of composer or from a different distribution (example: > https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/526262/1/composer/LICENSE). Why is that a problem? > And secondly, minimal installations (e.g. docker containers) of Debian that > don't keep doc/ around can no longer run composer install. That is definitely an issue. > Is there a reason we need the patch? We provide composer files in /usr/share/php, not in src/, so the LICENSE file is not available in ../ (i.e., /usr/share/). Furthermore, duplicating LICENSE information already provided in the package is usually a bad idea, but as you pointed out, we should not rely on /usr/share/doc at run time. I’ve updated the package to provide the upstream LICENSE file from /usr/share/php/data/Composer, so both issues should be fixed after the next upload, thanks. Regards. David
signature.asc
Description: OpenPGP digital signature
