Control: block -1 by 916454 Control: tags -1 + fixed-upstream On Fri, Aug 30, 2019 at 03:00:27PM +0100, Simon McVittie wrote: > Package: src:network-manager [...] > Usertags: py2removal > Control: block 936371 by -1 [...]
I had a quick look at this. Apparently upstream already supports using either python2 or python3 for tests (and fedora uses python3). cf. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/de326a4e8ad22a24e14c0f81821b0dd285860f22 I tried changing build-deps: - python-gi -> python3-gi - python-dbus -> python3-dbus I also needed to explicitly set PYTHON=python3 environment variable when calling dh_auto_configure, since python2 is transitively pulled in by gtk-doc-tools and AM_PATH_PYTHON will pick up python(2) first. I'm thus marking the gtk-doc-tools bug report about updating to a new upstream release (and switching to python3) as a blocker as there's no real point in fixing NM for py2removal if it still transitively deps on python2. With this I had problems with 2 failing tests that before my changes where skipped! I have no idea why the tests where no longer skipped.... Maybe someone else can easily spot it. Regards, Andreas Henriksson