Package: release.debian.org Severity: normal Tags: buster User: release.debian....@packages.debian.org Usertags: pu
gnome-sound-recorder 3.28.2-2 fixes a crash when a recording is played back with buster's version of gjs (#932076, #932389). I can only assume that this is not a heavily-used package among the GNOME team. The updated version still produces a lot of warnings for deprecated Javascript syntax, which I have not attempted to fix in the GNOME 3.28 branch since they seem non-critical. smcv
diffstat for gnome-sound-recorder-3.28.2 gnome-sound-recorder-3.28.2 changelog | 20 +++ gbp.conf | 4 patches/Fix-crashes-when-selecting-a-recording.patch | 109 +++++++++++++++++++ patches/series | 1 4 files changed, 132 insertions(+), 2 deletions(-) diff -Nru gnome-sound-recorder-3.28.2/debian/changelog gnome-sound-recorder-3.28.2/debian/changelog --- gnome-sound-recorder-3.28.2/debian/changelog 2019-01-11 15:58:29.000000000 +0000 +++ gnome-sound-recorder-3.28.2/debian/changelog 2019-09-08 11:36:53.000000000 +0100 @@ -1,3 +1,23 @@ +gnome-sound-recorder (3.28.2-2~deb10u1) buster; urgency=medium + + * Team upload + * Rebuild for Debian 10 + - d/gbp.conf: Set packaging branch to debian/buster + + -- Simon McVittie <s...@debian.org> Sun, 08 Sep 2019 11:36:53 +0100 + +gnome-sound-recorder (3.28.2-2) unstable; urgency=medium + + * Team upload + * d/p/Fix-crashes-when-selecting-a-recording.patch: + Add upstream patch fixing crashes with versions of gjs that expose + GtkContainer.widget (Closes: #932076, #932389) + * d/gbp.conf: Set packaging branch to debian/unstable and upstream + branch to upstream/3.28.x. The debian/master and upstream/latest + branches are already in use for versions >= 3.32 in experimental. + + -- Simon McVittie <s...@debian.org> Sun, 08 Sep 2019 11:15:17 +0100 + gnome-sound-recorder (3.28.2-1) unstable; urgency=medium * New upstream release diff -Nru gnome-sound-recorder-3.28.2/debian/gbp.conf gnome-sound-recorder-3.28.2/debian/gbp.conf --- gnome-sound-recorder-3.28.2/debian/gbp.conf 2019-01-11 15:58:29.000000000 +0000 +++ gnome-sound-recorder-3.28.2/debian/gbp.conf 2019-09-08 11:36:53.000000000 +0100 @@ -1,7 +1,7 @@ [DEFAULT] pristine-tar = True -debian-branch = debian/master -upstream-branch = upstream/latest +debian-branch = debian/buster +upstream-branch = upstream/3.28.x [buildpackage] sign-tags = True diff -Nru gnome-sound-recorder-3.28.2/debian/patches/Fix-crashes-when-selecting-a-recording.patch gnome-sound-recorder-3.28.2/debian/patches/Fix-crashes-when-selecting-a-recording.patch --- gnome-sound-recorder-3.28.2/debian/patches/Fix-crashes-when-selecting-a-recording.patch 1970-01-01 01:00:00.000000000 +0100 +++ gnome-sound-recorder-3.28.2/debian/patches/Fix-crashes-when-selecting-a-recording.patch 2019-09-08 11:36:53.000000000 +0100 @@ -0,0 +1,109 @@ +From: Jan Tojnar <jtoj...@gmail.com> +Date: Fri, 18 Jan 2019 00:48:25 +0100 +Subject: Fix crashes when selecting a recording + +bdaf42fb228f41d6920a28fee1fa9211c8d5ced4 removed widget property of MainWindow +class, causing crashes for some users. + +(cherry picked from commit 4dba2aa417829f4ccb465598707c8a5c43900fc3) + +Bug: https://gitlab.gnome.org/GNOME/gnome-sound-recorder/issues/39 +Bug-Debian: https://bugs.debian.org/932076 +Bug-Debian: https://bugs.debian.org/932389 +Origin: upstream, 3.28.3, commit:2b311ef67909bc20d0e87f334fe37bf5c4e9f29f +--- + src/mainWindow.js | 32 ++++++++++++++++---------------- + 1 file changed, 16 insertions(+), 16 deletions(-) + +diff --git a/src/mainWindow.js b/src/mainWindow.js +index 2b1e8f4..e4e2c83 100644 +--- a/src/mainWindow.js ++++ b/src/mainWindow.js +@@ -177,8 +177,8 @@ const MainView = new Lang.Class({ + if (play.getPipeStates() == PipelineStates.PLAYING) { + play.stopPlaying(); + let listRow = this.listBox.get_selected_row(); +- let rowWidget = listRow.get_child(this.widget); +- rowWidget.foreach(Lang.bind(this, ++ let rowGrid = listRow.get_child(); ++ rowGrid.foreach(Lang.bind(this, + function(child) { + + if (child.name == "PauseButton") { +@@ -578,8 +578,8 @@ const MainView = new Lang.Class({ + hasPreviousSelRow: function() { + this.destroyLoadMoreButton(); + if (previousSelRow != null) { +- let rowWidget = previousSelRow.get_child(this.widget); +- rowWidget.foreach(Lang.bind(this, ++ let rowGrid = previousSelRow.get_child(); ++ rowGrid.foreach(Lang.bind(this, + function(child) { + let alwaysShow = child.get_no_show_all(); + +@@ -628,9 +628,9 @@ const MainView = new Lang.Class({ + } + + previousSelRow = selectedRow; +- let selectedRowWidget = previousSelRow.get_child(this.widget); +- selectedRowWidget.show_all(); +- selectedRowWidget.foreach(Lang.bind(this, ++ let selectedRowGrid = previousSelRow.get_child(); ++ selectedRowGrid.show_all(); ++ selectedRowGrid.foreach(Lang.bind(this, + function(child) { + let alwaysShow = child.get_no_show_all(); + +@@ -650,8 +650,8 @@ const MainView = new Lang.Class({ + + _getFileFromRow: function(selected) { + let fileForAction = null; +- let rowWidget = selected.get_child(this.fileName); +- rowWidget.foreach(Lang.bind(this, ++ let rowGrid = selected.get_child(); ++ rowGrid.foreach(Lang.bind(this, + function(child) { + + if (child.name == "FileNameLabel") { +@@ -699,8 +699,8 @@ const MainView = new Lang.Class({ + + setNameLabel: function(newName, oldName, index) { + let selected = this.listBox.get_row_at_index(index); +- let rowWidget = selected.get_child(oldName); +- rowWidget.foreach(Lang.bind(this, ++ let rowGrid = selected.get_child(); ++ rowGrid.foreach(Lang.bind(this, + function(child) { + + if (child.name == "FileNameLabel") { +@@ -709,7 +709,7 @@ const MainView = new Lang.Class({ + child.label = markup; + } + })); +- rowWidget.set_name(newName); ++ rowGrid.set_name(newName); + }, + + onPause: function(listRow) { +@@ -717,8 +717,8 @@ const MainView = new Lang.Class({ + + if (activeState == PipelineStates.PLAYING) { + play.pausePlaying(); +- let rowWidget = listRow.get_child(this.widget); +- rowWidget.foreach(Lang.bind(this, ++ let rowGrid = listRow.get_child(); ++ rowGrid.foreach(Lang.bind(this, + function(child) { + + if (child.name == "PauseButton") { +@@ -741,8 +741,8 @@ const MainView = new Lang.Class({ + if (activeState != PipelineStates.PLAYING) { + play.startPlaying(); + +- let rowWidget = listRow.get_child(this.widget); +- rowWidget.foreach(Lang.bind(this, ++ let rowGrid = listRow.get_child(); ++ rowGrid.foreach(Lang.bind(this, + function(child) { + + if (child.name == "InfoButton" || child.name == "DeleteButton" || diff -Nru gnome-sound-recorder-3.28.2/debian/patches/series gnome-sound-recorder-3.28.2/debian/patches/series --- gnome-sound-recorder-3.28.2/debian/patches/series 2019-01-11 15:58:29.000000000 +0000 +++ gnome-sound-recorder-3.28.2/debian/patches/series 2019-09-08 11:36:53.000000000 +0100 @@ -0,0 +1 @@ +Fix-crashes-when-selecting-a-recording.patch