Hi Scott, Thanks for finally reviewing pywps.
On 9/13/19 5:23 PM, Scott Kitterman wrote: > One of our ftp-trainees reviewed your package and made the following > observations. It seems that the process is broken. This is far from the first time where an anonymous ftp-trainee commented on a package in NEW, but no ftp-master acted on this. What process does ftp-master use to review ftp-trainee comments? > Compiled works are present in tests/ and it does not appear this data can be > rebuilt > from the source package provided. Please remove and repack the tarball > to remove any such artifacts. Can you or or the anonymous ftp-trainee clarify which files they consider to be "Compiled works"? There are data files under tests/data & tests/requests used in various tests. Why should these need to be rebuilt if those are the files in question? > Data in pywps/schemas/geojson/ has no licensing information. Its upstream states: "[...] either of the AFL or BSD license", but not which version. I've contacted the author to request clarification. > Who holds an actual copyright is confusing: > - LICENSE.txt claims copyright by "PyWPS Development Team" > - All source claims copyright by "Open Source Geospatial Foundation" Why does this matter? debian/copyright includes the holders as listed in LICENSE.txt and the sources. Are you saying that's wrong? > - Source also (incorrectly) uses "and others" as a copyright holder Why is this incorrect? The sources have copyright statements like this: Copyright 2018 Open Source Geospatial Foundation and others licensed under MIT, Please consult LICENSE.txt for details That's what's reflected in debian/copyright. > - d/copyright claims "PyWPS Project Steering Committee" is a copyright > holder, but is > not represented in source It used to be a copyright holder, see: debian/share/pywps/processes/sayhello.py > Files provided in d/patches have a copyright holder that is not present in > d/copyright > This appears to be the new maintainer, they should be included in the > debian/* paragraph. The patches are trivial and cannot be copyrighted in my understanding. I wave any copyright claims on them if they can. Depending on how strict ftp-master is on the data files issue, it may be better to just remove this package from Debian as I don't use it myself and just co-maintain it because it's also included in OSGeoLive. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1