Source: uphpmvault
Version: 0.8
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs

uphpmvault fails to cross build from source, because both make and make
install strip with the wrong strip. Beyond breaking cross compilation,
this also breaks DEB_BUILD_OPTIONS=nostrip as well as generation of
-dbgsym packages. It is best to defer stripping to dh_strip. Please
consider applying the attached patch.

Helmut
diff --minimal -Nru uphpmvault-0.8/Makefile uphpmvault-0.8+nmu1/Makefile
--- uphpmvault-0.8/Makefile     2011-05-02 19:07:50.000000000 +0200
+++ uphpmvault-0.8+nmu1/Makefile        2019-09-18 16:07:56.000000000 +0200
@@ -13,6 +13,7 @@
 CFLAGS:=-O2 -g
 LFLAGS:=-g
 CFLAGS += -Wall -Wformat -Wstrict-aliasing
+INSTALL?=install
 
 .PHONY: all
 all: $(TARGETS)
@@ -22,13 +23,11 @@
 uphpmvault: $(uphpmvault_OBJS)
        @echo "LINK       " $@
        @$(CXX) -o $@ $^ $(LFLAGS)
-       @cp $@ $@_unstripped
-       @strip $@
 
 .PHONY: install
 install:
-       install -d $(DESTDIR)/usr/bin
-       install -s uphpmvault $(DESTDIR)/usr/bin
+       $(INSTALL) -d $(DESTDIR)/usr/bin
+       $(INSTALL) -s uphpmvault $(DESTDIR)/usr/bin
 
 .PHONY: build
 build:
diff --minimal -Nru uphpmvault-0.8/debian/changelog 
uphpmvault-0.8+nmu1/debian/changelog
--- uphpmvault-0.8/debian/changelog     2011-07-03 20:03:10.000000000 +0200
+++ uphpmvault-0.8+nmu1/debian/changelog        2019-09-18 16:13:03.000000000 
+0200
@@ -1,3 +1,10 @@
+uphpmvault (0.8+nmu1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Defer stripping to dh_strip. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de>  Wed, 18 Sep 2019 16:13:03 +0200
+
 uphpmvault (0.8) unstable; urgency=low
 
   * Added stddef.h s.t. offsetof macro is available.  Required by GCC 4.6.  
(closes: bug#632569)
diff --minimal -Nru uphpmvault-0.8/debian/rules uphpmvault-0.8+nmu1/debian/rules
--- uphpmvault-0.8/debian/rules 2008-06-25 06:53:22.000000000 +0200
+++ uphpmvault-0.8+nmu1/debian/rules    2019-09-18 16:09:21.000000000 +0200
@@ -1,3 +1,6 @@
 #!/usr/bin/make -f
 %:
        dh $@
+
+override_dh_auto_install:
+       dh_auto_install -- INSTALL='install --strip-program=true'

Reply via email to