On 18/09/2019 22:21, Debian Bug Tracking System wrote:
This is an automatic notification regarding your Bug report
which was filed against the gnustep-base-runtime package:
#939119: gnustep-base-runtime: Upgrading to Debian 10 causes gdomap
network service to become enabled
It has been closed by Yavor Doganov <ya...@gnu.org>.
Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Yavor Doganov
<ya...@gnu.org> by
replying to this email.
[resend: try to fix non-html formatting]
Thanks Yavor, and everyone else. But now I can see the code laid out,
I'm not sure the newly added preinst is doing anything.
# Upgrades from stretch to buster have made the gdomap daemon enabled
# by default which is undesirable. Explicitly delete the symlinks and
# let update-rc.d recreate them in postinst. See #939119.
# Remove after bullseye is released.
if [ "$1" = "upgrade" ]; then
if dpkg --compare-versions "$2" lt 1.26.0-5; then
if [ ! -h /etc/rc2.d/S*gdomap ]; then
find /etc/rc?.d -name "*gdomap" -delete
fi
fi
fi
We only reset the symlinks - i.e. disable the init script - when the
[S]tart symlink does not exist - i.e. the init script is already disabled?
Shouldn't it look like the below? (I've bumped the package version here :)
if [ "$1" = "upgrade" ]; then
if dpkg --compare-versions "$2" lt 1.26.0-6; then
if [ -f /etc/default/gdomap ]; then
if ( . /etc/default/gdomap; [ "$ENABLED" = "no" ]); then
find /etc/rc?.d -name "*gdomap" -delete
fi
fi
fi
fi
If we don't have an ENABLED= line, because we already hit this bug, then
I think we just don't have the information. We have to make the
choice. Either preserve the current enabled status, as I do above. Or
check we don't have ENABLED=yes, then guess the user was in the "99.5%",
and force the service to be disabled.
Warm regards
Alan
