Hi Roland, On Tue, Oct 15, 2019 at 05:28:58PM +0200, Roland Rosenfeld wrote: > Hi Ralf! > > Thanks for your bug report! > > On Di, 15 Okt 2019, Ralf Treinen wrote: > > > Package: rancid-cgi > > Version: 3.10-1 > > User: [email protected] > > Tags: patch > > Usertags: colis-shparser > > > if /etc/rancid/apache.conf is a directory, the preinst will fail > > after possibly having removed /etc/rancid/lg.conf. This modification > > cannot be rolled back. > > > > We suggest to inverse the order in the script : > > > > if [ -e /etc/rancid/apache.conf ]; then > > rm /etc/rancid/apache.conf > > fi > > if [ -h /etc/rancid/lg.conf ]; then > > rm /etc/rancid/lg.conf > > fi > > > > This way, if /etc/rancid/apache.conf is a directory, the script will > > fail immediately. Note that the following conditional command > > cannot fail. > > As far as I can see, this preinst file is very ancient and tries to > fix even older mistakes in the package. > > From my point of view, the best solution would be to remove all of the > above, because it is no longer needed. Nobody should upgraded from > pre 2.2.2-3 to 3.10 any more. > > Any objections?
thanks a lot for your prompt reply ! Yes, if this code is no longer necessary then the best is IMHO to remove it. Cheers -Ralf. -- Ralf Treinen Institut de Recherche en Informatique Fondamentale Équipe Preuves, Programmes et Systèmes Université Paris Diderot, Paris, France. http://www.irif.fr/~treinen/
