Hi Axel Yes I think we should try that. If fallocate is not recommended at all, we could just entirely get rid of the if clause? This would simplify things, i.e. we wouldn't need the whitelist.
Best regards Cyrill On Tue, Oct 22, 2019 at 4:25 PM Axel Beckert <a...@debian.org> wrote: > Control: fixed -1 20100506-5 > > Hi Cyrill, > > Cyrill Helg wrote: > > Package: dphys-swapfile > > Version: 20100506-5 > [...] > > please update the part of detecting fallocate as the exit code of > > the type command causes the script to stop if fallocate is not > > found. > > fallocate is no more used since dphys-swapfile 20100506-5 as it > does only work on specific file systems and mkswap explicitly > recommends to not use it. > > Do you think we should reinstatiate that Debian- (and derivatives) > specific patch which has not been accepted upstream and add your patch > on top plus a either a whitelist filesystems which work with fallocate > (preferred) or a blacklist of filesystems which don't work (your > suggestion)? > > Regards, Axel > -- > ,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/ > : :' : | Debian Developer, ftp.ch.debian.org Admin > `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 > `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE >
