[2019-10-24 13:45] Lorenzo Puliti <lorenzo.r...@gmail.com>
> Package: runit
> Version: 2.1.2-35
> Severity: wishlist
> Tags: patch
>
> Hi,
Hi!
> while doing another round of testing with openssh-server i've found
> some minor problem that might need a fix. Detailed description is in
> git commit message.
Something is missing? I see patch 2/2, but not 1/2.
> From bb212cbba9d01476f4a9c29a81c07e7c922c078f Mon Sep 17 00:00:00 2001
> From: Lorenzo Puliti <lorenzo.r...@gmail.com>
> Date: Thu, 24 Oct 2019 11:59:05 +0200
> Subject: [PATCH 2/2] minor improvements to invoke-run
>
> * be verbose about uninstalled binary
> * fix indentation in previous patch [1d28c60d] replacing spaces with TAB
> * redirect output of {$initscripts} stop to /dev/null (it goes to
> service log otherwise); it is confusing to see a stop message during
> service startup
> ---
> debian/contrib/lib/invoke-run | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/debian/contrib/lib/invoke-run b/debian/contrib/lib/invoke-run
> index 2a11306..54e6d47 100755
> --- a/debian/contrib/lib/invoke-run
> +++ b/debian/contrib/lib/invoke-run
> @@ -38,15 +38,16 @@ if [ -f "/etc/sv/${service}/.meta/installed" ] ; then
> # uninstalled, but not purged. See #929693 and commit [4c485b]
> # in dh-runit repository.
> if ! [ -f "${installed}" ] ; then
> + echo "runsv: $NAME binary not installed"
Does not check for VERBOSE.
> sv down "${service}"
> exit 0
> fi
> fi
>
> if [ -r /etc/default/runit ]; then
> - set -a
> - . /etc/default/runit
> - set +a
> + set -a
> + . /etc/default/runit
> + set +a
> fi
Indentation change. I do not see why it is necessary, but if it is,
please move to separate commit.
> if [ -r "/etc/default/${service}" ] ; then
> @@ -69,7 +70,7 @@ if [ -x "${initscript}" ] ; then
> exit 0
> fi
> fi
> - "${initscript}" stop
> + "${initscript}" stop >/dev/null
Why?
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.
