Source: backuppc
Version: 3.2.2-2
Severity: important
Tags: patch
The reload block of the init script does not specify a user to
start-stop-daemon. Since the PID file is not owned by root this results
in an error.
Worse, under systemd the unit is then marked failed and cannot be
recovered without restarting the daemon. If a backup or restore is in
progress that can be very disruptive.
Patch attached, making the reload block match the others.
-- System Information:
Debian Release: 10.2
APT prefers proposed-updates
APT policy: (990, 'proposed-updates'), (500, 'stable-updates'), (500,
'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-6-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Index: backuppc-3.3.2/init.d/src/debian-backuppc
===================================================================
--- backuppc-3.3.2.orig/init.d/src/debian-backuppc
+++ backuppc-3.3.2/init.d/src/debian-backuppc
@@ -54,7 +54,7 @@ case "$1" in
;;
reload|force-reload)
echo "Reloading $NAME configuration files"
- start-stop-daemon --stop --pidfile $LOGDIR/BackupPC.pid \
+ start-stop-daemon --stop --pidfile $LOGDIR/BackupPC.pid -u $USER \
--signal 1 -x /usr/bin/perl
;;
*)
