Sebastien Bacher <seb...@debian.org> writes: > because it uses more memory than available. The attached patch makes it > build with --no-parallel which workarounds the issue, what would you
Hm, this seems to be the wrong place to put this? If a build machine has too little memory for a --parallel build of a package, that is a property of the build machine, not of the package. So better if the individual build machine sets DEB_BUILD_OPTIONS=parallel=1 or similar. IIUC, this is how it is done in the Debian build infrastructure. (A refinement could be if the build machine could set DEB_LOW_MEM_BUILDER or something that could conditionally disable parallel build on heavy packages. Such mechanism should be general across packages (not specific to openscad), not sure if something like that is available). The patch penalises _every_ build which is bad - building with -jN makes a huge difference in compile time for openscad, and should work fine on modern-sized machines. Also, IIUC, the patch would disable parallel not just for the build but also for the test run? That would again be bad, the testsuite also benefits hugely from parallel build, and I do not think parallel test suite requires a lot of memory. - Kristian.