[2019-11-13 14:35] Lorenzo Puliti <lorenzo.r...@gmail.com>
> >Are you sure about "wrong sh syntax" part?
>
> You are right, this is very inaccurate. Just for the records, I've
> made some tests :
> [...]
>
> * invoke-run exits before executing run's file code --> exit -1

Can you please elaborate on this case? How could runsv(1) know whether
"run" file was read or not?

> From 36efd3382ed5908d1f53e8ba38193aab4e38e157 Mon Sep 17 00:00:00 2001
> From: Lorenzo Puliti <lorenzo.r...@gmail.com>
> Date: Mon, 4 Nov 2019 19:48:37 +0100
> Subject: [PATCH 1/2] Add finish-default
>
> Add a finish-default file to be sourced from finish scripts
>
> Closes: #943397

Good. Thanks. Please, removed trailing newline and I think you want to
set executable bit.

> From f1cb3095e88293e715d320cc36bbbd333b8531f5 Mon Sep 17 00:00:00 2001
> From: Lorenzo Puliti <lorenzo.r...@gmail.com>
> Date: Tue, 5 Nov 2019 23:49:58 +0100
> Subject: [PATCH 2/2] Update invoke-run manpage for finish-default
>
> Update invoke-run manpage to account for finish-default file and
> special error codes.
> [...]

> +can be found in the run file, looking for lines like
> +.PP
> +.IP "" 6
> +.EX
> +sv start dep1  &&  sv check dep1  ||  exit 170

I think I already pointed that dependencies could be started with
code like this (or in any other form), so specifying exact pattern may
be misleading.

        # some code that sets $@
        sv start "$@"

Not sure how to better put it. What about something like following:

        [...] to know dependencies of service look for "sv start" in "run"
        script.
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.

Reply via email to