On Mon, 2019-12-16 at 02:00 +0000, Jelmer Vernooij wrote: > The Janitor is a specific bot that happens to run lintian-brush (among > other things). I think it would be confusing if other things used this > identity.
Interesting, I didn't know that it ran things other than lintian-brush. I suggest that the Janitor should attribute things to the right tool. > > * lintian-brush <[email protected]> > This seems reasonable. Perhaps it would make sense to set committer to > the person who ran the tool, and author to "lintian-brush > <[email protected]>" ? Sounds good, I'd leave the committer as the default from the user's VCS configuration though. > > * Person running the tool, but attribute the tool in the footer: > > Changed-by: lintian-brush --options-here I made a typo, I meant to write Changes-by. > That's a good idea; I think providing the options (and lintian-brush > version?) in the commit may be useful regardless of what choice we > make about committer/author. Seems reasonable to include the version number to me. -- bye, pabs https://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part
