control: tags -1 patch pending
Hello, since this is delaying boost transition, and blocking 3 RC bug fixes, I
uploaded it in deferred/5
let me know if I can speed it up, or feel free to delete it if you don't like
the change
G.
On Fri, 3 Jan 2020 19:35:20 +0100 Gianfranco Costamagna
<locutusofb...@debian.org> wrote:
> Source: autoconf-archive
> Version: 20190106-2
> Severity: serious
>
> Hello, esys-particle is FTBFS with python3, because the following:
> dh_auto_configure -- $(extra_flags)
> --with-boost-libdir=/usr/lib/$(DEB_HOST_MULTIARCH)
> --with-boost-python='boost_python$(PY3VER)'
>
>
> tanslates the build into a "boost_python37" link line
>
> checking whether boost_python37 is the correct library... yes
>
> /bin/bash ../libtool --tag=CXX --mode=link mpicxx -Wall -g -O2
> -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
> -Werror=format-security -release 2.3.4 -L/usr/lib/i386-linux-gnu
> -lboost_system -lpython3.7m -Wl,-z,relro -Wl,-z,now -o libFoundation.la
> -rpath /usr/lib/i386-linux-gnu libFoundation_la-console.lo
> libFoundation_la-Counter.lo libFoundation_la-Matrix3.lo
> libFoundation_la-Quaternion.lo libFoundation_la-vec3.lo
> libFoundation_la-Timer.lo libFoundation_la-StringUtil.lo
> libFoundation_la-realdist.lo libFoundation_la-PathSearcher.lo
> libFoundation_la-Runnable.lo libFoundation_la-PathUtil.lo
> libFoundation_la-Rng.lo libFoundation_la-BoundingSphere.lo
> libFoundation_la-BoundingBox.lo libFoundation_la-cube_eq.lo
> -lboost_filesystem boost_python37 -lpython3.7m -lmpi++ -lmpi
>
> note the missing "-l" on python, while it is there for the filesystem link.
>
> The following patch fixes the issue, and I would like to NMU it ASAP if you
> agree.
>
> Author: Gianfranco Costamagna <locutusofb...@debian.org>
> Last-Update: 2020-01-03
>
> --- autoconf-archive-20190106.orig/m4/ax_boost_python.m4
> +++ autoconf-archive-20190106/m4/ax_boost_python.m4
> @@ -109,7 +109,7 @@ if test "$ac_cv_boost_python" = "yes"; t
> BOOST_PYTHON_MODULE(test) { throw "Boost::Python test."; }]], [])],
> [AS_VAR_SET([ax_Lib], [yes])],
> [AS_VAR_SET([ax_Lib], [no])])])
> - AS_VAR_IF([ax_Lib], [yes], [BOOST_PYTHON_LIB=$ax_lib break], [])
> + AS_VAR_IF([ax_Lib], [yes], [BOOST_PYTHON_LIB=-l$ax_lib break], [])
> AS_VAR_POPDEF([ax_Lib])dnl
> done
> AC_SUBST(BOOST_PYTHON_LIB)
>
>
> It looks like just an obvious typo, I'll upstream the fix soon.
>
> G.
diff -Nru autoconf-archive-20190106/debian/changelog
autoconf-archive-20190106/debian/changelog
--- autoconf-archive-20190106/debian/changelog 2019-09-03 20:44:43.000000000
+0200
+++ autoconf-archive-20190106/debian/changelog 2020-01-03 19:46:30.000000000
+0100
@@ -1,3 +1,12 @@
+autoconf-archive (20190106-2.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/patches/0001-ax_boost_python.m4-fix-missing-l-parameter-
+ resulting.patch: Upstream proposed fix for python boost wrong linking
+ Closes: #948078
+
+ -- Gianfranco Costamagna <locutusofb...@debian.org> Fri, 03 Jan 2020
19:46:30 +0100
+
autoconf-archive (20190106-2) unstable; urgency=medium
* Upload to unstable
diff -Nru
autoconf-archive-20190106/debian/patches/0001-ax_boost_python.m4-fix-missing-l-parameter-resulting.patch
autoconf-archive-20190106/debian/patches/0001-ax_boost_python.m4-fix-missing-l-parameter-resulting.patch
---
autoconf-archive-20190106/debian/patches/0001-ax_boost_python.m4-fix-missing-l-parameter-resulting.patch
1970-01-01 01:00:00.000000000 +0100
+++
autoconf-archive-20190106/debian/patches/0001-ax_boost_python.m4-fix-missing-l-parameter-resulting.patch
2020-01-03 19:46:30.000000000 +0100
@@ -0,0 +1,45 @@
+From 596a3bb21e9084a751117d47018ddd2943f92bb5 Mon Sep 17 00:00:00 2001
+From: Gianfranco Costamagna <costamagnagianfra...@yahoo.it>
+Date: Fri, 3 Jan 2020 19:36:53 +0100
+Subject: [PATCH] ax_boost_python.m4: fix missing "-l" parameter, resulting
+ into a link failure when used.
+
+configuring a project with something like:
+--with-boost-libdir=/usr/lib/$(DEB_HOST_MULTIARCH)
--with-boost-python='boost_python3.7'
+
+tanslates the build into a "boost_python37" link line
+
+checking whether boost_python37 is the correct library... yes
+
+/bin/bash ../libtool --tag=CXX --mode=link mpicxx -Wall -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -release 2.3.4 -L/usr/lib/i386-linux-gnu
-lboost_system -lpython3.7m -Wl,-z,relro -Wl,-z,now -o libFoundation.la -rpath
/usr/lib/i386-linux-gnu libFoundation_la-console.lo libFoundation_la-Counter.lo
libFoundation_la-Matrix3.lo libFoundation_la-Quaternion.lo
libFoundation_la-vec3.lo libFoundation_la-Timer.lo
libFoundation_la-StringUtil.lo libFoundation_la-realdist.lo
libFoundation_la-PathSearcher.lo libFoundation_la-Runnable.lo
libFoundation_la-PathUtil.lo libFoundation_la-Rng.lo
libFoundation_la-BoundingSphere.lo libFoundation_la-BoundingBox.lo
libFoundation_la-cube_eq.lo -lboost_filesystem boost_python37 -lpython3.7m
-lmpi++ -lmpi
+
+note the missing "-l" on python, while it is there for the filesystem link.
+---
+ m4/ax_boost_python.m4 | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/m4/ax_boost_python.m4 b/m4/ax_boost_python.m4
+index 41826be..28e35b6 100644
+--- a/m4/ax_boost_python.m4
++++ b/m4/ax_boost_python.m4
+@@ -53,7 +53,7 @@
+ # modified version of the Autoconf Macro, you may extend this special
+ # exception to the GPL to apply to your modified version as well.
+
+-#serial 22
++#serial 23
+
+ AC_DEFUN([AX_BOOST_PYTHON],
+ [AC_REQUIRE([AX_PYTHON_DEVEL])dnl
+@@ -109,7 +109,7 @@ if test "$ac_cv_boost_python" = "yes"; then
+ BOOST_PYTHON_MODULE(test) { throw "Boost::Python test."; }]], [])],
+ [AS_VAR_SET([ax_Lib], [yes])],
+ [AS_VAR_SET([ax_Lib], [no])])])
+- AS_VAR_IF([ax_Lib], [yes], [BOOST_PYTHON_LIB=$ax_lib break], [])
++ AS_VAR_IF([ax_Lib], [yes], [BOOST_PYTHON_LIB=-l$ax_lib break], [])
+ AS_VAR_POPDEF([ax_Lib])dnl
+ done
+ AC_SUBST(BOOST_PYTHON_LIB)
+--
+2.17.1
+
diff -Nru autoconf-archive-20190106/debian/patches/series
autoconf-archive-20190106/debian/patches/series
--- autoconf-archive-20190106/debian/patches/series 1970-01-01
01:00:00.000000000 +0100
+++ autoconf-archive-20190106/debian/patches/series 2020-01-03
19:46:30.000000000 +0100
@@ -0,0 +1 @@
+0001-ax_boost_python.m4-fix-missing-l-parameter-resulting.patch
