Bug#950287: autofs: automount expriing unmounts target filesystem

[Mike Gabriel]

Control: close -1
Control: fixed -1 5.1.5-1

Hi,

On  Fr 31 Jan 2020 12:47:15 CET, Ian Kent wrote:

On Fri, 2020-01-31 at 19:35 +0800, Ian Kent wrote:

On Fri, 2020-01-31 at 19:29 +0800, Ian Kent wrote:
> On Fri, 2020-01-31 at 19:16 +0800, Ian Kent wrote:
> > On Fri, 2020-01-31 at 07:55 +0100, Marc Lehmann wrote:
> > > > > Sounds like I have enough information to duplicate the
> > > > > problem
> > > > > so
> > > > > I'll have a look see.
> > > >
> > > > Oh, as usual, what's the autofs source version of your
> > > > package
> > > > please,
> > > > since I'll be using the current development source to work on
> > > > it.
> > >
> > > It's the one mentioned in my original report (that you probably
> > > didn't
> > > get): 5.1.2-4
> >
> > I grabbed the Debian source package and unpacked it on an old
> > Ubuntu
> > VM I have.
> >
> > It looks like this package has the change that adds handling of
> > symlinks to umount_multi() so this should not be calling umount()
> > at all.
>
> Ahh, Haa, I see the problem in the Debian package source.
>
> As you say, there is a call to is_mounted() (which calls that
> ioctl)
> at the top of umount_multi():
>
>        if (is_mounted(_PATH_MOUNTED, path, MNTS_ALL))
>                 goto real_mount;
>
> and that branches to the real mount umount code, this is now gone
> in the current source.
>
> I'll have a look at the change history and see if I can locate
> the patch (or patches) that removed it.

There it is, and it looks independent of other changes ...

autofs-5.1.3 - fix symlink false negative in umount_multi()

And you can find this at:
https://mirrors.edge.kernel.org/pub/linux/daemons/autofs/v5/patches-5.1.4/autofs-5.1.3-fix-symlink-false-negative-in-umount_multi.patch

Ian

Mike
--

mike gabriel aka sunweaver (Debian Developer)
mobile: +49 (1520) 1976 148
landline: +49 (4351) 486 14 27

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: sunwea...@debian.org, http://sunweavers.net

Thanks for clarifying, Ian. Much appreciated. I have marked the issue as resolved in Debian for autofs 5.1.5-1 (there were no 5.1.3 / 5.1.4 uploads in Debian due to orphaned package state). Marc, as I get it, it would be welcome to get the discussed issue fixed in Debian stable (aka buster). Right?

pgppSgipYDhTx.pgp
Description: Digitale PGP-Signatur